qml: Add a dedicated Popup for the Teletext settings

This MR embeds the Teletext settings into a dedicated Popup that the user triggers when clicking on the dedicated button. This button is part of the default navigation presets and filtered out depending on the media.

This makes the player toolbar cleaner while retaining the comprehensive Teletext options and potentially adding new ones in the future.

changed the description

added 2 commits

• 5e247b8a - qml/TeletextWidget: Add a SubtitleLabel for the title
• 6735c2e6 - qml/PlaybackSpeed(s): Fix keyboard navigation

Compare with previous version

added MRStatus::NotCompliant label

added MRStatus::Reviewable label and removed MRStatus::NotCompliant label

changed the description

added Component::Interface: Qt label

mentioned in merge request !2371 (merged)

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::Reviewable label

added MRStatus::InReview label and removed MRStatus::Acceptable label

added 7 commits

• 9ae47943 - qml/controlbarcontrols: Create TeletextButton
• 3ced5a91 - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• 7840db40 - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 5b633367 - qml/NavigationWidget: Update to TeletextButton
• 3fb32325 - qml/TeletextWidget: Remove 'paintOnly' property
• 8219b48b - qml/TeletextWidget: Add a SubtitleLabel for the title
• a85068fc - qml/PlaybackSpeed(s): Fix keyboard navigation

Compare with previous version

added 7 commits

• 925809ad - qml/controlbarcontrols: Create TeletextButton
• 096a1b7f - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• c8476add - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 0486946d - qml/NavigationWidget: Update to TeletextButton
• b45f547f - qml/TeletextWidget: Remove 'paintOnly' property
• b9149f18 - qml/TeletextWidget: Add a SubtitleLabel for the title
• f4b5e21f - qml/PlaybackSpeed(s): Fix keyboard navigation

Compare with previous version

up action on playback speed button doesn't move focus on seekbar

added 7 commits

• 9b2fc107 - qml/controlbarcontrols: Create TeletextButton
• 9a8ddba8 - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• f145cb67 - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 7e4fbf57 - qml/NavigationWidget: Update to TeletextButton
• 18d62338 - qml/TeletextWidget: Remove 'paintOnly' property
• fef98c22 - qml/TeletextWidget: Add a SubtitleLabel for the title
• e6ffa09e - qml/PlaybackSpeed(s): Fix keyboard navigation

Compare with previous version

added 7 commits

• 18a2c535 - qml/controlbarcontrols: Create TeletextButton
• 0884d16f - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• de30d521 - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• f52b14ae - qml/NavigationWidget: Update to TeletextButton
• 5876e5ce - qml/TeletextWidget: Remove 'paintOnly' property
• 2f165b91 - qml/TeletextWidget: Add a SubtitleLabel for the title
• 7bdf2140 - qml/PlaybackSpeed(s): Fix keyboard navigation

Compare with previous version

changed milestone to %4.0

added MRStatus::NotCompliant label and removed MRStatus::InReview label

The teletex popup probably deserve some design improvement:

• poor layouting, the spinbox is not aligned with the rest of the buttons
• icons starts to be really confusing, when the menu is opened you have the same icon 3 time on screen (see your screenshot)
• transparency icon doesn't provide any way to know whether it's active or not

it probably need to be checked with the designer, maybe something like this would work

added 163 commits

• 7bdf2140...9e19c47f - 154 commits from branch videolan:master
• b67b9397 - qml/controlbarcontrols: Create TeletextButton
• 822a65fd - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• 124e532a - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 7f27d84d - qml/NavigationWidget: Update to TeletextButton
• e6ab5baa - qml/TeletextWidget: Remove 'paintOnly' property
• 7be4bb94 - qml/TeletextWidget: Add a SubtitleLabel for the title
• 99507629 - qml/PlaybackSpeed(s): Fix keyboard navigation
• ff6373b5 - qml/TeletextWidget: Update contentSize(s) implementation
• 5ddfad2f - qml/NavigationWidget: Fix 'row' implicit width

Compare with previous version

resolved all threads

added MRStatus::Acceptable label and removed MRStatus::NotCompliant label

added MRStatus::InReview label and removed MRStatus::Acceptable label

added 9 commits

• 201f66ef - qml/controlbarcontrols: Create TeletextButton
• 230d6cee - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• 701ad2bd - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 4869007f - qml/NavigationWidget: Update to TeletextButton
• 7b9fdd10 - qml/TeletextWidget: Remove 'paintOnly' property
• 6f7d5c73 - qml/TeletextWidget: Add a SubtitleLabel for the title
• 2b36a0e9 - qml/PlaybackSpeed(s): Fix keyboard navigation
• 4e4eade5 - qml/TeletextWidget: Update contentSize(s) implementation
• d73c6186 - qml/NavigationWidget: Fix 'row' implicit width

Compare with previous version

resolved all threads

added 9 commits

• 5e0b43ba - qml/controlbarcontrols: Create TeletextButton
• 61495a02 - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• 397b61d5 - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 9b74e216 - qml/NavigationWidget: Update to TeletextButton
• 7d5a6237 - qml/TeletextWidget: Remove 'paintOnly' property
• 61c072f0 - qml/TeletextWidget: Add a SubtitleLabel for the title
• d76a620e - qml/PlaybackSpeed(s): Fix keyboard navigation
• 89c7e918 - qml/TeletextWidget: Update contentSize(s) implementation
• 55e9830c - qml/NavigationWidget: Fix 'row' implicit width

Compare with previous version

added MRStatus::Acceptable label and removed MRStatus::InReview label

added MRStatus::NotCompliant label and removed MRStatus::Acceptable label

added 40 commits

• 55e9830c...63ac5078 - 31 commits from branch videolan:master
• e4e89e0e - qml/controlbarcontrols: Create TeletextButton
• a9128b9d - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• 94baba54 - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• 1b7e74f3 - qml/NavigationWidget: Update to TeletextButton
• a6c19616 - qml/TeletextWidget: Remove 'paintOnly' property
• 0da72458 - qml/TeletextWidget: Add a SubtitleLabel for the title
• 3b999543 - qml/PlaybackSpeed(s): Fix keyboard navigation
• a8a0305b - qml/TeletextWidget: Update contentSize(s) implementation
• 4f903522 - qml/NavigationWidget: Fix 'row' implicit width

Compare with previous version

added MRStatus::Accepted label and removed MRStatus::NotCompliant label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 19 commits

• 4f903522...35acecef - 10 commits from branch videolan:master
• ed203d0e - qml/controlbarcontrols: Create TeletextButton
• 5cc7975d - qml/ControlbarControls: Update TELETEXT_BUTTONS to TeletextButton.qml
• aa3de67d - qt/control_list_filter: Add TELETEXT_BUTTONS filter
• d6ae5886 - qml/NavigationWidget: Update to TeletextButton
• 99ca9c4f - qml/TeletextWidget: Remove 'paintOnly' property
• 37a55445 - qml/TeletextWidget: Add a SubtitleLabel for the title
• a749fb90 - qml/PlaybackSpeed(s): Fix keyboard navigation
• 0c1cf3bf - qml/TeletextWidget: Update contentSize(s) implementation
• 2a02bdf3 - qml/NavigationWidget: Fix 'row' implicit width

Compare with previous version

enabled an automatic merge when the pipeline for 2a02bdf3 succeeds

merged