Skip to content
Snippets Groups Projects

Revert "smb2: fix anonymous login"

Merged Thomas Guillem requested to merge tguillem/vlc:smb2-fix-anonynous-n48431564 into master

This reverts commit 205963ad.

According to git blame on libsmb2, anonymous login was always enabled with a NULL password.

I don't know what happened when I tested this reverted commit, I may have mix up VLC or/and smb/smb2/dsm builds.

For future reference, see libsmb2/lib/ntlmssp.c:

...
encode_ntlm_auth(...)
{
...
    if (auth_data->password == NULL) {
            anonymous = 1;
            goto encode;
    }
...
}

Fixes #27113 (closed)

Edited by Thomas Guillem

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading