Revert "smb2: fix anonymous login"
This reverts commit 205963ad.
According to git blame on libsmb2, anonymous login was always enabled with a NULL password.
I don't know what happened when I tested this reverted commit, I may have mix up VLC or/and smb/smb2/dsm builds.
For future reference, see libsmb2/lib/ntlmssp.c:
...
encode_ntlm_auth(...)
{
...
if (auth_data->password == NULL) {
anonymous = 1;
goto encode;
}
...
}
Fixes #27113 (closed)
Merge request reports
Activity
changed milestone to %4.0
added Component::Input: file system label
assigned to @tguillem
added MRStatus::Reviewable label
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, and score >= 0 -
MergeRequest should have no activity (threads/votes) for (24h/24h)
-
added 7 commits
-
ab61197a...2fdb6af0 - 6 commits from branch
videolan:master
- 06692b49 - Revert "smb2: fix anonymous login"
-
ab61197a...2fdb6af0 - 6 commits from branch
enabled an automatic merge when the pipeline for 06692b49 succeeds