Skip to content

[3.0] contrib: upnp: disable webserver and device handling

Alaric Senat requested to merge asenat/vlc:fix/disable-upnp-webserver into 3.0.x

VLC 3.0 uses libupnp exclusively as a client. LibUpnp internals are quite opaque and it has been observed that a webserver thread is still running on idle with open sockets even if the library is used as a client only.

The recent bump to 1.14 introduces regressions in libupnp's webserver socket initialization [1] on windows. Since the bug is still not corrected upstream and we don't have any use of the webserver for 3.0 anyway, let's just disable it.

This patch makes an exception for IOS as it has been observed that this specific configuration creates infinite loops for for this platform [2]. As the goal of the patch is mainly to fix regression on windows so we can release 3.0.18, it should be safer, for now, to let the configuration as it was for IOS.

[1] https://github.com/pupnp/pupnp/issues/195 [2] https://github.com/pupnp/pupnp/issues/328

Fixes #27001 (closed)

Edited by Alaric Senat

Merge request reports