Skip to content
Snippets Groups Projects

taglib: Fix uses of custom resolvers with IOStream

Merged Hugo Beauzée-Luyssen requested to merge chouquette/vlc:taglib/1 into master
All threads resolved!

Merge request reports

Merge request pipeline #191457 passed

Merge request pipeline passed for 89e20ea0

Merged by Hugo Beauzée-LuyssenHugo Beauzée-Luyssen 3 years ago (Feb 17, 2022 8:31pm UTC)

Merge details

Pipeline #191574 passed

Pipeline passed for 89e20ea0 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 44 commits

    • 59239078...e308b8c8 - 39 commits from branch videolan:master
    • 0058cca3 - taglib: Remove explicit invocation of default constructor
    • fde44972 - contrib: taglib: Fix custom resolvers with IOStream
    • 0e3f42a5 - taglib: Implement new StreamTypeResolver interface when available
    • 23990c82 - taglib: Reduce FileRef scope
    • 2c081784 - taglib: Use nullptr instead of 0 for pointers

    Compare with previous version

  • Rémi Denis-Courmont resolved all threads

    resolved all threads

  • MR Acceptance result

    :tada: This MergeRequest has been Accepted! Congratulations.

    MR acceptance checks details:

    • :white_check_mark: MR should be considered mergeable by Gitlab
    • :white_check_mark: Last pipeline should be successful
    • :white_check_mark: MergeRequest should have at least one external review and/or vote
    • :white_check_mark: All threads should be resolved, and score >= 0
    • :white_check_mark: MergeRequest should have no activity (threads/votes) for (24h/24h)

    This message was automatically generated by homer-bot.

  • added 9 commits

    • 2c081784...c7c21555 - 4 commits from branch videolan:master
    • 93842f65 - taglib: Remove explicit invocation of default constructor
    • 2f82d6b9 - contrib: taglib: Fix custom resolvers with IOStream
    • 268b5b8b - taglib: Implement new StreamTypeResolver interface when available
    • 98c7c135 - taglib: Reduce FileRef scope
    • 89e20ea0 - taglib: Use nullptr instead of 0 for pointers

    Compare with previous version

  • Hugo Beauzée-Luyssen enabled an automatic merge when the pipeline for 89e20ea0 succeeds

    enabled an automatic merge when the pipeline for 89e20ea0 succeeds

  • Please register or sign in to reply
    Loading