configure broked?

[root@underpants vlc]# ./configure --disable-a52 checking for GL... ./configure: line 53413: syntax error near unexpected token else' ./configure: line 53413: else'

[root@underpants vlc]# uname -a Linux underpants 2.6.32-358.14.1.el6.centos.plus.i686 #1 (closed) SMP Tue Jul 16 20:51:25 UTC 2013 i686 i686 i386 GNU/Linux

Unreproducible

added Status::needs more info label

closed

/bin/sh on CentOS does not allow empty if statements so this is broken on CentOS. It may be that /bin/sh on other distributions is more forgiving.

Anyway, the fix is easy, add a dummy command ":" to configure.ac to avoid an empty if statement in the generated configure script.

diff --git a/configure.ac b/configure.ac
index 7d0a8ab..ae6d18e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -2991,6 +2991,7 @@ PKG_CHECK_MODULES([GL], [gl], [
     GL_CFLAGS=""
     AS_IF([test "${SYS}" = "mingw32"], [
       AC_CHECK_HEADER([GL/glew.h], [
+        :
       ], [
         have_gl="no"
       ])

removed Status::needs more info label

reopened

assigned to @Courmisch

added Status::fixed label

changed milestone to %2.2.x maintenance branch

closed

commit 25c43a8a Author: Rémi Denis-Courmont remi@remlab.net Date: Fri Jan 10 18:11:17 2014 +0200

configure: fix shell syntax (fixes [#9571](https://code.videolan.org/videolan/vlc/-/issues/9571))

Original author: remi@remlab.net