Follow-up from "Improve bitcode support in VLC" - Stray LDFLAGS_libvlc in pkg-config file
The following discussion from !182 (merged) should be addressed:
-
@mstorsjo started a discussion: (+7 comments) The fact that the
VLC_ADD_LIBS
line is removed here means thatAC_SUBST(LIBS_libvlc)
never gets called. This leads to a stray@LIBS_libvlc@
being left behind in lib/libvlc.pc, e.g. asLibs.private: -lvlccore @LIBS_libvlc@
. This then leads to a broken build in npapi-vlc. Apparently this part of the build isn't tested in the CI?What do you think is the best way to fix it - remove the
@LIBS_libvlc@
from the pkg-config file (now that nothing gets added to it)? Or change it toLDFLAGS_libvlc
or something like that (if that flag is relevant for users of libvlc)?
Possible solutions discussed:
- build sample in CI with installed libvlc
- build npapi in CI