Skip to content

Improve bitcode support in VLC

Alexandre Janniaux requested to merge alexandre-janniaux/vlc:improve-bitcode-support/1 into master

This merge request improves the support of bitcode in dynamic builds of libvlc.

In particular, the current bitcode support works through CFLAGS-like variable only, because it's currently only used as a static build. When building dynamically, -fembed-bitcode wasn't given to the linker.

By enabling -fembed-bitcode at the linker stage, multiple issues arise:

  • libtool eats the -fembed-bitcode flag because it doesn't know about it.
  • bitcode and “advanced“ functions from the linker are not compatible (undefined, -U, -read_only_relocs in particular).
  • bitcode and mach-o bundles are not compatibles (-bundle is triggered by default by -module with libtool, since old runtime linkers were not able to dlopen/dlclose a dylib, but it's not the case anymore for a long time).
  • because -Wl,-U cannot be used, we cannot provide weak undefined symbols at all, so it's not possible to make the static module bank work.

This MR address those issues and disable the static module bank in that case.

Edited by Alexandre Janniaux

Merge request reports

VideoLAN code repository instance