"Set up associations..." in preferences doesn't work correctly

It appears only the window which is used for XP, not the UI for Vista and higher.

Cause:

hr = CoInitializeEx( NULL, COINIT_MULTITHREADED );
if( SUCCEEDED(hr) )
{
...
}

Return value is 0x80010106 (RPC_E_CHANGED_MODE, Cannot change thread mode after it is set)

This appears since commit 39e4fad1

As workaround, this will work:

hr = CoInitializeEx( NULL, COINIT_MULTITHREADED );
if( SUCCEEDED(hr) || hr == RPC_E_CHANGED_MODE )
{
...
}

No way this is correct.

And sorry, but your ticket is impossible to understand:

It appears only the window which is used for XP, not the UI for Vista and higher.

WHAT?

Replying to [comment:2 jb]:

And sorry, but your ticket is impossible to understand:

It appears only the window which is used for XP, not the UI for Vista and higher.

WHAT? On Vista and above, this window should appear:

But currently, the window for WinXP and lower appears on vista and above, too:

Added attachment:

• 1.png

Added attachment:

• 2.png

From this line, the window for XP will be created:

http://git.videolan.org/?p=vlc.git;a=blob;f=modules/gui/qt4/components/simple_preferences.cpp;h=2a93bb0bee0d5c23254c7ad06c302f256429ce47;hb=HEAD#l1280

The code above this line opens the window for vista and higher.

Before commit 39e4fad1, CoInitializeEx() was not checked with HRESULT, and the issue was not visible.

added Status::fixed label

changed milestone to %3.0.0

closed

commit 656562f3077f3520d09b3ec4071ff3c121635980 Author: Rémi Denis-Courmont remi@remlab.net Date: Wed Apr 8 18:58:18 2015 +0300

Qt4: allow either COM model for associations (fixes [#14323](https://code.videolan.org/videolan/vlc/-/issues/14323))

The model does not matter here as affected objects do not outlive the
function call and are not used across threads. Still the references
counter of the apartment must remain balanced.

Original author: remi@remlab.net

Backported

changed milestone to %2.2.1

Sorry, but it still doesn't work.

I think there is a typo. It works with this code:

if( hr == RPC_E_CHANGED_MODE )
    hr = CoInitializeEx( NULL, COINIT_APARTMENTTHREADED );

commit aa9976b1 Author: Rémi Denis-Courmont remi@remlab.net Date: Wed Apr 8 18:58:18 2015 +0300

Qt4: allow either COM model for associations (fixes [#14323](https://code.videolan.org/videolan/vlc/-/issues/14323))

The model does not matter here as affected objects do not outlive the
function call and are not used across threads. Still the references
counter of the apartment must remain balanced.

Original author: remi@remlab.net

Duplicate of #11953 (closed)

added Difficulty::hard label