2.2 regression: TagLib art lost on adding slave or updating meta

Regressions introduced by commit e4673369.

See also commit fdb9f79e and #11966 (closed).

added Component::Core: Input Severity::normal Type::bug Version::master git + 1 deleted label

changed milestone to %Bugs paradize

changed milestone to %2.2.0

François, an idea?

artUrl not set after setting attachments to trigger art update ?

Is there any sample using taglib to understand what is the problem ?

As above, the problem is e4673369 clears all attachments blindly whenever (one of) the demuxer flags a meta-data update. That is OK if the cleared attachment came from the same demuxer; that is NOT OK if the attachments came from the meta engine or from another demuxer (in case the input has slaves).

Replying to [ticket:11976 courmisch]:

Regressions introduced by commit e4673369.

See also commit fdb9f79e and #11966 (closed).

Any further details or screenshots describing this bug?

I don't understand the question. I gave the reference to where and when the problem got introduced and what the problem is. I cannot be more specific.

commit 223a42c1 Author: Timothy B. Terriberry tterribe@xiph.org Date: Sat Sep 20 10:16:33 2014 -0700

input: Tag attachments with the demuxer that produced them

This way, when metadata is updated, we only replace the attachments
produced by the demuxer whose metadata changed.

Fixes [#11976](https://code.videolan.org/videolan/vlc/-/issues/11976)

Tested by reverting the patch in [#11966](https://code.videolan.org/videolan/vlc/-/issues/11966) (with some fix-ups to pass the
right arguments where the code had changed).

Signed-off-by: Rémi Denis-Courmont <remi@remlab.net>

Original author: tterribe@xiph.org

added Status::fixed label

closed