Regression: MP4: no cover art anymore

http://streams.videolan.org/issues/11966/FRAGMENT-Sonata.m4a

To check, please empty your art cache and disable download.

added Component::Demuxers Severity::normal Type::bug Version::master git + 1 deleted label

changed milestone to %2.2.0

changed the description

assigned to @fcartegnie and unassigned @MigrationBot

The issue is: [000000000111a508] core libvlc error: no suitable access module for `attachment://cover'

Because input_thread_t *input = access_GetParentInput(access); return NULL;

So it might be a core issue.

courmisch might have a clever idea here.

The art URL is set to "cover", and the demux only defines "picture0".

I don't see anywhere access_GetParentInput() returns NULL.

It seems the cover attachment set by TagLib is systematically discarded by InputUpdateMeta(). I do not have the courage to bisect, but I strongly suspect that this change is the culprit:

commit e4673369e8356c84ca99b66fb222dee07c8e4962
Author: Timothy B. Terriberry <tterribe@xiph.org>
Date:   Wed Apr 24 21:50:42 2013 -0700

    Update attachments when updating metadata.
    
    This makes album art work for formats like Vorbis and Opus which do
     not have metadata available immediately after Open().
    
    Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

And reverting e4673369 solves the bug.

assigned to @Courmisch and unassigned @fcartegnie

added Status::fixed label

closed

commit fdb9f79e Author: Rémi Denis-Courmont remi@remlab.net Date: Fri Aug 15 20:07:07 2014 +0300

input: fetch demux attachment once, not twice (fixes [#11966](https://code.videolan.org/videolan/vlc/-/issues/11966))

This was inefficient and caused attachments from the meta engine or from
the slave demuxers to get lost.

Note that those attachments will still get lost later if the master
demuxer sets the metadata update flag (which affects the Ogg demuxer
only so far), or when adding a slave input.

All regressions introduced in e4673369e8356c84ca99b66fb222dee07c8e4962.

Original author: remi@remlab.net

added Component::Demuxers: MP4 label and removed Component::Demuxers label

mentioned in issue #11976 (closed)