Skip to content
Snippets Groups Projects

Compare revisions

Changes are shown as if the source revision was being merged into the target revision. Learn more about comparing revisions.

Source

Select target project
No results found

Target

Select target project
  • videolan/vlc
  • chouquette/vlc
  • bakiewicz.marek122/vlc
  • devnexen/vlc
  • rohanrajpal/vlc
  • blurrrb/vlc
  • gsoc/gsoc2019/darkapex/vlc
  • b1ue/vlc
  • fkuehne/vlc
  • magsoft/vlc
  • chub/vlc
  • cramiro9/vlc
  • robUx4/vlc
  • rom1v/vlc
  • akshayaky/vlc
  • tmk907/vlc
  • akymaster/vlc
  • govind.sharma/vlc
  • psilokos/vlc
  • xjbeta/vlc
  • jahan/vlc
  • 1480c1/vlc
  • amanchande/vlc
  • aaqib/vlc
  • rist/vlc
  • apol/vlc
  • mindfreeze/vlc
  • alexandre-janniaux/vlc
  • sandsmark/vlc
  • jagannatharjun/vlc
  • gsoc/gsoc2020/matiaslgonzalez/vlc
  • gsoc/gsoc2020/jagannatharjun/vlc
  • mstorsjo/vlc
  • gsoc/gsoc2020/vedenta/vlc
  • gsoc/gsoc2020/arnav-ishaan/vlc
  • gsoc/gsoc2020/andreduong/vlc
  • fuzun/vlc
  • gsoc/gsoc2020/vatsin/vlc
  • gsoc/gsoc2020/sagid/vlc
  • yaron/vlc
  • Phoenix/vlc
  • Garf/vlc
  • ePiratWorkarounds/vlc
  • tguillem/vlc
  • jnqnfe/vlc
  • mdc/vlc
  • Vedaa/vlc
  • rasa/vlc
  • quink/vlc
  • yealo/vlc
  • aleksey_ak/vlc
  • ePirat/vlc
  • ilya.yanok/vlc
  • asenat/vlc
  • m/vlc
  • bunjee/vlc
  • BLumia/vlc
  • sagudev/vlc
  • hamedmonji30/vlc
  • nullgemm/vlc
  • DivyamAhuja/vlc
  • thesamesam/vlc
  • dag7/vlc
  • snehil101/vlc
  • haasn/vlc
  • jbk/vlc
  • ValZapod/vlc
  • mfkl/vlc
  • WangChuan/vlc
  • core1024/vlc
  • GhostVaibhav/vlc
  • dfuhrmann/vlc
  • davide.prade/vlc
  • tmatth/vlc
  • Courmisch/vlc
  • zouya/vlc
  • hpi/vlc
  • EwoutH/vlc
  • aleung27/vlc
  • hengwu0/vlc
  • saladin/vlc
  • ashuio/vlc
  • richselwood/vlc
  • verma16Ayush/vlc
  • chemicalflash/vlc
  • PoignardAzur/vlc
  • huangjieNT/vlc
  • Blake-Haydon/vlc
  • AnuthaDev/vlc
  • gsoc/gsoc2021/mpd/vlc
  • nicolas_lequec/vlc
  • sambassaly/vlc
  • thresh/vlc
  • bonniegong/vlc
  • myaashish/vlc
  • stavros.vagionitis/vlc
  • ileoo/vlc
  • louis-santucci/vlc
  • cchristiansen/vlc
  • sabyasachi07/vlc
  • AbduAmeen/vlc
  • ashishb0410/vlc
  • urbanhusky/vlc
  • davidepietrasanta/vlc
  • riksleutelstad/vlc
  • jeremyVignelles/vlc
  • komh/vlc
  • iamjithinjohn/vlc
  • JohannesKauffmann/vlc2
  • kunglao/vlc
  • natzberg/vlc
  • jill/vlc
  • cwendling/vlc
  • adufou/vlc
  • ErwanAirone/vlc
  • HasinduDilshan10/vlc
  • vagrantc/vlc
  • rafiv/macos-bigsur-icon
  • Aymeriic/vlc
  • saranshg20/vlc
  • metzlove24/vlc
  • linkfanel/vlc
  • Ds886/vlc
  • metehan-arslan/vlc
  • Skantes/vlc
  • kgsandundananjaya96/vlc
  • mitchcapper/vlc
  • advaitgupta/vlc
  • StefanBruens/vlc
  • ratajs/vlc
  • T.M.F.B.3761/vlc
  • m222059/vlc
  • casemerrick/vlc
  • joshuaword2alt/vlc
  • sjwaddy/vlc
  • dima/vlc
  • Ybalrid/vlc
  • umxprime/vlc
  • eschmidt/vlc
  • vannieuwenhuysenmichelle/vlc
  • badcf00d/vlc
  • wesinator/vlc
  • louis/vlc
  • xqq/vlc
  • EmperorYP7/vlc
  • NicoLiam/vlc
  • loveleen/vlc
  • rofferom/vlc
  • rbultje/vlc
  • TheUnamed/vlc
  • pratiksharma341/vlc
  • Saurab17/vlc
  • purist.coder/vlc
  • Shuicheng/vlc
  • mdrrubel292/vlc
  • silverbleu00/vlc
  • metif12/vlc
  • asher-m/vlc
  • jeffk/vlc
  • Brandonbr1/vlc
  • beautyyuyanli/vlc
  • rego21/vlc
  • muyangren907/vlc
  • collectionbylawrencejason/vlc
  • evelez/vlc
  • GSMgeeth/vlc
  • Oneric/vlc
  • TJ5/vlc
  • XuanTung95/vlc
  • darrenjenny21/vlc
  • Trenly/vlc
  • RockyTDR/vlc
  • mjakubowski/vlc
  • caprica/vlc
  • ForteFrankie/vlc
  • seannamiller19/vlc
  • junlon2006/vlc
  • kiwiren6666/vlc
  • iuseiphonexs/vlc
  • fenngtun/vlc
  • Rajdutt999/vlc
  • typx/vlc
  • leon.vitanos/vlc
  • robertogarci0938/vlc
  • gsoc/gsoc2022/luc65r/vlc-mpd
  • skeller/vlc
  • MCJack123/vlc
  • luc65r/vlc-mpd
  • popov895/vlc
  • claucambra/vlc
  • brad/vlc
  • matthewmurua88/vlc
  • Tomas8874/vlc
  • philenotfound/vlc
  • makita-do3/vlc
  • LZXCorp/vlc
  • mar0x/vlc
  • senojetkennedy0102/vlc
  • shaneb243/vlc
  • ahmadbader/vlc
  • rajduttcse26/vlc-audio-filters
  • Juniorzito8415/vlc
  • achernyakov/vlc
  • lucasjetgroup/vlc
  • pupdoggy666/vlc
  • gmde9363/vlc
  • alexnwayne/vlc
  • bahareebrahimi781/vlc
  • hamad633666/vlc
  • umghof3112/vlc
  • joe0199771874/vlc
  • Octocats66666666/vlc
  • jjm_223/vlc
  • btech10110.19/vlc
  • sunnykfc028/vlc-audio-filters
  • loic/vlc
  • nguyenminhducmx1/vlc
  • JanekKrueger/vlc
  • bstubbington2/vlc
  • rcombs/vlc
  • Ordissimo/vlc
  • king7532/vlc
  • noobsauce101/vlc
  • schong0525/vlc
  • myQwil/vlc
  • apisbg91/vlc
  • geeboy0101017/vlc
  • kim.faughey/vlc
  • nurupo/vlc
  • yyusea/vlc
  • 0711235879.khco/vlc
  • ialo/vlc
  • iloveyeye2/vlc
  • gdtdftdqtd/vlc
  • leandroconsiglio/vlc
  • AndyHTML2012/vlc
  • ncz/vlc
  • lucenticus/vlc
  • knr1931/vlc
  • kjoonlee/vlc
  • chandrakant100/vlc-qt
  • johge42/vlc
  • polter/vlc
  • hexchain/vlc
  • Tushwrld/vlc
  • mztea928/vlc
  • jbelloncastro/vlc
  • alvinhochun/vlc
  • ghostpiratecrow/vlc
  • ujjwaltwitx/vlc
  • alexsonarin06/vlc
  • adrianbon76/vlc
  • altsod/vlc
  • damien.lucas44/vlc
  • dmytrivtaisa/vlc
  • utk202/vlc
  • aaxhrj/vlc
  • thomas.hermes/vlc
  • structurenewworldorder/vlc
  • slomo/vlc
  • wantlamy/vlc
  • musc.o3cminc/vlc
  • thebarshablog/vlc
  • kerrick/vlc
  • kratos142518/vlc
  • leogps/vlc
  • vacantron/vlc
  • luna_koly/vlc
  • Ratio2/vlc
  • anuoshemohammad/vlc
  • apsun/vlc
  • aaa1115910/vlc
  • alimotmoyo/vlc
  • Ambossmann/vlc
  • Sam-LearnsToCode/vlc
  • Chilledheart/vlc
  • Labnann/vlc
  • ktcoooot1/vlc
  • mohit-marathe/vlc
  • johnddx/vlc
  • manstabuk/vlc
  • Omar-ahmed314/vlc
  • vineethkm/vlc
  • 9Enemi86/vlc
  • radoslav.m.panteleev/vlc
  • ashishami2002/vlc
  • Corbax/vlc
  • firnasahmed/vlc
  • pelayarmalam4/vlc
  • c0ff330k/vlc
  • shikhindahikar/vlc
  • l342723951/vlc
  • christianschwandner/vlc
  • douniwan5788/vlc
  • 7damian7/vlc
  • ferdnyc/vlc
  • f.ales1/vlc
  • pandagby/vlc
  • BaaBaa/vlc
  • jewe37/vlc
  • w00drow/vlc
  • russelltg/vlc
  • ironicallygod/vlc
  • soumyaDghosh/vlc
  • linzihao1999/vlc
  • deyayush6/vlc
  • mibi88/vlc
  • newabdallah10/vlc
  • jhorbincolombia/vlc
  • rimvihaqueshupto/vlc
  • andrewkhon98/vlc
  • fab78/vlc
  • lapaz17/vlc
  • amanna13/vlc
  • mdakram28/vlc
  • 07jw1980/vlc
  • sohamgupta/vlc
  • Eson-Jia1/vlc
  • Sumou/vlc
  • vikram-kangotra/vlc
  • chalice191/vlc
  • olivercalder/vlc
  • aaasg4001/vlc
  • zipdox/vlc
  • kwizart/vlc
  • Dragon-S/vlc
  • jdemeule/vlc
  • gabriel_lt/vlc
  • locutusofborg/vlc
  • sammirata/vlc-librist
  • another/vlc
  • Benjamin_Loison/vlc
  • ahmedmoselhi/vlc
  • petergaal/vlc
  • huynhsontung/vlc
  • dariusmihut/vlc
  • tvermaashutosh/vlc
  • buti/vlc
  • Niram7777/vlc
  • rohan-here/vlc
  • balaji-sivasakthi/vlc
  • rlindner81/vlc
  • Kakadus/vlc
  • djain/vlc
  • ABBurmeister/vlc
  • craighuggins/vlc
  • orbea/vlc
  • maxos/vlc
  • aakarshmj/vlc
  • kblaschke/vlc
  • ankitm/vlc
  • advait-0/vlc
  • mohak2003/vlc
  • yselkowitz/vlc
  • AZM999/vlc-azm
  • andrey.turkin/vlc
  • Disha-Baghel/vlc
  • nowrep/vlc
  • Apeng/vlc
  • Choucroute_melba/vlc
  • autra/vlc
  • eclipseo/vlc
  • fhuber/vlc
  • olafhering/vlc
  • sdasda7777/vlc
  • 1div0/vlc
  • skosnits/vlc-extended-playlist-support
  • dnicolson/vlc
  • Timshel/vlc
  • octopols/vlc
  • MangalK/vlc
  • nima64/vlc
  • misawai/vlc
  • Alexander-Wilms/vlc
  • Maxime2/vlc-fork-for-visualizer
  • ww/vlc
  • jeske/vlc
  • sgross-emlix/vlc
  • morenonatural/vlc
  • freakingLovesVLC/vlc
  • borisgolovnev/vlc
  • mpromonet/vlc
  • diogo.simao-marques/vlc
  • masstock/vlc
  • pratikpatel8982/vlc
  • hugok79/vlc
  • longervision/vlc
  • abhiudaysurya/vlc
  • rishabhgarg/vlc
  • tumic/vlc
  • cart/vlc
  • shubham442/vlc
  • Aditya692005/vlc
  • sammirata/vlc4
  • syrykh/vlc
  • Vvorcun/macos-new-icon
  • AyaanshC/vlc
  • nasso/vlc
  • Quark/vlc
  • sebastinas/vlc
  • rhstone/vlc
  • talregev/vlc
  • Managor/vlc
  • abdsaber000/vlc
  • falbrechtskirchinger/vlc
405 results
Show changes
Commits on Source (7)
  • Lyndon Brown's avatar
    dtv: fix bad option default · 7e3cba83
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    0 was not in the choice list.
    
    it looks like 0 was interpreted by the code as the same as -1 via
    `dvb_parse_transmit_mode()`, so not a big problem.
    7e3cba83
  • Lyndon Brown's avatar
    mono: fix bad option default · 93211094
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    -1 was not in the choice list.
    
    this adds the missing choice list entry corresponding to the default.
    i've made a guess at the right label and explanation to use based upon
    what seems to be happening with a -1 value in `stereo_to_mono()` and
    from bits of git history relating to it.
    93211094
  • Lyndon Brown's avatar
    rtp: fix bad option default · 0a68d39d
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    NULL does not map to an entry in the choice list.
    
    also, mark the choice labels for translation.
    0a68d39d
  • Lyndon Brown's avatar
    upnp: improve auto mode handling code · 31f283ad
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    (no functional change)
    
     - better prepare for the next commit where we need to support both "Auto"
       and "auto".
     - avoid multiple `strdup()`.
     - avoid avoidable string comparisons.
    31f283ad
  • Lyndon Brown's avatar
    upnp: fix bad option default · 230068f3
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    the lowercase "auto" default option value did not match the uppercase
    "Auto" in the choice list.
    
    option values should typically be lowercase. this fixes the mistake with
    the case of the choice value, whilst maintaining backwards compatibility
    with existing CLI usage and from saved settings files. this was the
    clear preference for fixing this resulting from the MR discussion.
    230068f3
  • Lyndon Brown's avatar
    visual: fix bad option default · fb842279
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    "flat" is not in the choice list and is meaningless to the module, not
    matching any of its known presets. it is thus equivalent to a default of
    "none". (see `window_get_param()` in `modules/visualization/visual/window.c`
    which describes this as falling back to "using rectangular window (i.e. no
    window)").
    
    it is a reasonable assumption that the author meant the default to be the
    `"flattop"` choice, and just made a mistake here, however this is not
    certain and the preference expressed in review was to preserve the existing
    behaviour by switching to "none".
    fb842279
  • Lyndon Brown's avatar
    svg: fix default outside of valid range · 94fb7feb
    Lyndon Brown authored and Jean-Baptiste Kempf's avatar Jean-Baptiste Kempf committed
    caused options to always be adjusted to value of 1 when saving prefs.
    94fb7feb
......@@ -283,7 +283,7 @@ vlc_module_begin ()
add_integer ("dvb-bandwidth", 0, BANDWIDTH_TEXT, NULL)
change_integer_list (bandwidth_vlc, bandwidth_user)
change_safe ()
add_integer ("dvb-transmission", 0,
add_integer ("dvb-transmission", -1,
TRANSMISSION_TEXT, NULL)
change_integer_list (transmission_vlc, transmission_user)
change_safe ()
......
......@@ -539,8 +539,8 @@ error:
"(between 96 and 127) if it can't be determined otherwise with " \
"out-of-band mappings (SDP)" )
static const char *const dynamic_pt_list[] = { "theora" };
static const char *const dynamic_pt_list_text[] = { "Theora Encoded Video" };
static const char *const dynamic_pt_list[] = { "", "theora" };
static const char *const dynamic_pt_list_text[] = { N_( "Unset" ), N_( "Theora Encoded Video" ) };
/*
* Module descriptor
......@@ -580,7 +580,7 @@ vlc_module_begin()
add_integer("rtp-max-misorder", 100, RTP_MAX_MISORDER_TEXT,
RTP_MAX_MISORDER_LONGTEXT)
change_integer_range (0, 32767)
add_string("rtp-dynamic-pt", NULL, RTP_DYNAMIC_PT_TEXT,
add_string("rtp-dynamic-pt", "", RTP_DYNAMIC_PT_TEXT,
RTP_DYNAMIC_PT_LONGTEXT)
change_string_list(dynamic_pt_list, dynamic_pt_list_text)
......
......@@ -82,9 +82,10 @@ typedef struct
#define MONO_CHANNEL_LONGTEXT N_("This option silences all other channels " \
"except the selected channel.")
static const int pi_pos_values[] = { 0, 1, 4, 5, 7, 8, 2, 3, 6 };
static const int pi_pos_values[] = { -1, 0, 1, 4, 5, 7, 8, 2, 3, 6 };
static const char *const ppsz_pos_descriptions[] =
{ N_("Left"), N_("Right"),
{ N_("Stereo mix"),
N_("Left"), N_("Right"),
N_("Rear left"), N_("Rear right"),
N_("Center"), N_("Low-frequency effects"),
N_("Side left"), N_("Side right"), N_("Rear center") };
......
......@@ -66,10 +66,10 @@ vlc_module_begin ()
add_shortcut( "svg" )
/* svg options */
add_integer_with_range( "svg-width", -1, 1, 65535,
add_integer_with_range( "svg-width", -1, -1, 65535,
TEXT_WIDTH, LONG_TEXT_WIDTH )
change_safe()
add_integer_with_range( "svg-height", -1, 1, 65535,
add_integer_with_range( "svg-height", -1, -1, 65535,
TEXT_HEIGHT, LONG_TEXT_HEIGHT )
change_safe()
......
......@@ -72,7 +72,7 @@ const char* SATIP_SERVER_DEVICE_TYPE = "urn:ses-com:device:SatIPServer:1";
#define URL_LONGTEXT N_("The Url used to get the xml descriptor of the UPnP Renderer")
static const char *const ppsz_satip_channel_lists[] = {
"Auto", "ASTRA_19_2E", "ASTRA_28_2E", "ASTRA_23_5E", "MasterList", "ServerList", "CustomList"
"auto", "ASTRA_19_2E", "ASTRA_28_2E", "ASTRA_23_5E", "MasterList", "ServerList", "CustomList"
};
static const char *const ppsz_readible_satip_channel_lists[] = {
N_("Auto"), "Astra 19.2°E", "Astra 28.2°E", "Astra 23.5°E", N_("SAT>IP Main List"), N_("Device List"), N_("Custom List")
......@@ -647,12 +647,20 @@ MediaServerList::parseSatipServer( IXML_Element* p_device_element, const char *p
SD::MediaServerDesc* p_server = NULL;
char *psz_satip_channellist = config_GetPsz("satip-channelist");
if( !psz_satip_channellist ) {
psz_satip_channellist = strdup("Auto");
}
if( unlikely( !psz_satip_channellist ) )
return;
/* In Auto mode, default to MasterList list from satip.info */
bool automode = false;
if( !psz_satip_channellist || /* On lookup failure or empty string, use auto mode */
strcmp(psz_satip_channellist, "auto") == 0 ||
strcmp(psz_satip_channellist, "Auto") == 0 ) /* for backwards compatibility */
{
automode = true;
if( psz_satip_channellist )
free(psz_satip_channellist);
psz_satip_channellist = strdup( "MasterList" );
if( unlikely( !psz_satip_channellist ) )
return;
}
vlc_url_t url;
vlc_UrlParse( &url, psz_base_url );
......@@ -681,8 +689,7 @@ MediaServerList::parseSatipServer( IXML_Element* p_device_element, const char *p
/* Part 2: device playlist
* In Automatic mode, or if requested by the user, check for a SAT>IP m3u list on the device */
if (strcmp(psz_satip_channellist, "ServerList") == 0 ||
strcmp(psz_satip_channellist, "Auto") == 0 ) {
if (automode || strcmp(psz_satip_channellist, "ServerList") == 0) {
const char* psz_m3u_url = xml_getChildElementValue( p_device_element, "satip:X_SATIPM3U" );
if ( psz_m3u_url ) {
if ( strncmp( "http", psz_m3u_url, 4) )
......@@ -712,7 +719,7 @@ MediaServerList::parseSatipServer( IXML_Element* p_device_element, const char *p
msg_Dbg( m_sd, "SAT>IP server '%s' did not provide a playlist", url.psz_host);
}
if(strcmp(psz_satip_channellist, "ServerList") == 0) {
if (!automode) {
/* to comply with the SAT>IP specifications, we don't fallback on another channel list if this path failed,
* but in Automatic mode, we continue */
free(psz_satip_channellist);
......@@ -726,12 +733,6 @@ MediaServerList::parseSatipServer( IXML_Element* p_device_element, const char *p
* which will be processed by a lua script a bit later, to make it work sanely
* MasterList is a list of usual Satellites */
/* In Auto mode, default to MasterList list from satip.info */
if( strcmp(psz_satip_channellist, "Auto") == 0 ) {
free(psz_satip_channellist);
psz_satip_channellist = strdup( "MasterList" );
}
char *psz_url;
if (asprintf( &psz_url, "http://www.satip.info/Playlists/%s.m3u",
psz_satip_channellist ) < 0 ) {
......
......@@ -126,7 +126,7 @@ vlc_module_begin ()
WIDTH_TEXT, WIDTH_LONGTEXT )
add_integer("effect-height" , VOUT_HEIGHT ,
HEIGHT_TEXT, HEIGHT_LONGTEXT )
add_string("effect-fft-window", "flat",
add_string("effect-fft-window", "none",
FFT_WINDOW_TEXT, FFT_WINDOW_LONGTEXT )
change_string_list( window_list, window_list_text )
add_float("effect-kaiser-param", 3.0f,
......