Commits on Source (7)
-
0 was not in the choice list. it looks like 0 was interpreted by the code as the same as -1 via `dvb_parse_transmit_mode()`, so not a big problem.
7e3cba83 -
-1 was not in the choice list. this adds the missing choice list entry corresponding to the default. i've made a guess at the right label and explanation to use based upon what seems to be happening with a -1 value in `stereo_to_mono()` and from bits of git history relating to it.
93211094 -
NULL does not map to an entry in the choice list. also, mark the choice labels for translation.
0a68d39d -
(no functional change) - better prepare for the next commit where we need to support both "Auto" and "auto". - avoid multiple `strdup()`. - avoid avoidable string comparisons.
31f283ad -
the lowercase "auto" default option value did not match the uppercase "Auto" in the choice list. option values should typically be lowercase. this fixes the mistake with the case of the choice value, whilst maintaining backwards compatibility with existing CLI usage and from saved settings files. this was the clear preference for fixing this resulting from the MR discussion.
230068f3 -
"flat" is not in the choice list and is meaningless to the module, not matching any of its known presets. it is thus equivalent to a default of "none". (see `window_get_param()` in `modules/visualization/visual/window.c` which describes this as falling back to "using rectangular window (i.e. no window)"). it is a reasonable assumption that the author meant the default to be the `"flattop"` choice, and just made a mistake here, however this is not certain and the preference expressed in review was to preserve the existing behaviour by switching to "none".
fb842279 -
caused options to always be adjusted to value of 1 when saving prefs.
94fb7feb
Showing
- modules/access/dtv/access.c 1 addition, 1 deletionmodules/access/dtv/access.c
- modules/access/rtp/rtp.c 3 additions, 3 deletionsmodules/access/rtp/rtp.c
- modules/audio_filter/channel_mixer/mono.c 3 additions, 2 deletionsmodules/audio_filter/channel_mixer/mono.c
- modules/codec/svg.c 2 additions, 2 deletionsmodules/codec/svg.c
- modules/services_discovery/upnp.cpp 16 additions, 15 deletionsmodules/services_discovery/upnp.cpp
- modules/visualization/visual/visual.c 1 addition, 1 deletionmodules/visualization/visual/visual.c