Commits on Source (3)
-
b697c740
-
Lock fmt on read/write since it's written from the DecoderThread and read anywhere (when creating a meter module from the player).
936295ab -
Reset the meter fmt to NULL when destroying the stream. WARNING: ThreadSanitizer: heap-use-after-free (pid=45968) Read of size 1 at 0x7b4400019fdc by main thread: #0 aout_filter_Create ../../src/audio_output/filters.c:56 (libvlccore.so.9+0xa4945) #1 vlc_audio_meter_CreatePluginFilter ../../src/audio_output/meter.c:83 (libvlccore.so.9+0xa7074) #2 vlc_audio_meter_AddPlugin ../../src/audio_output/meter.c:108 (libvlccore.so.9+0xa71df) #3 aout_AddMeterPlugin ../../src/audio_output/output.c:1008 (libvlccore.so.9+0xaa088) #4 vlc_player_AddMetadataLoudnessListener ../../src/player/metadata.c:106 (libvlccore.so.9+0x98f93) #5 vlc_player_AddMetadataListener ../../src/player/metadata.c:181 (libvlccore.so.9+0x990bc) #6 test_audio_loudness_meter ../../test/src/player/player.c:2842 (test_src_player+0x5db2) #7 main ../../test/src/player/player.c:2961 (test_src_player+0xa9fa) Previous write of size 8 at 0x7b4400019fd8 by main thread: #0 free ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:711 (libtsan.so.0+0x368a8) #1 vlc_player_track_priv_Delete ../../src/player/track.c:145 (libvlccore.so.9+0x94d60) #2 vlc_player_track_Delete ../../src/player/track.c:153 (libvlccore.so.9+0x94d7d) #3 ctx_reset ../../test/src/player/player.c:630 (test_src_player+0x484d) #4 test_end ../../test/src/player/player.c:1044 (test_src_player+0x5696) #5 test_es_selection_override ../../test/src/player/player.c:2913 (test_src_player+0x5b18) #6 main ../../test/src/player/player.c:2960 (test_src_player+0xa9f2)
27ffece6