Not needed anymore since this variable is always locked by the owner->lock.

In order to merge the usage of the same lock and avoid locking it twice
in a row. This new status struct be used to get the status of sub ES
tracks created by decoder modules.

Prince Gupta authored 3 years ago and Pierre Lamot committed 3 years ago

parentId property was removed in cd89555e

  both the intf and the vout window reference the qt interface structure
  it will only be released once not used by both modules, this way the windows
  continues to exists if the interface is closed before.

  When the interface module is released before the vout window, the qml view and
  the associated resources are unloaded from the compositor.

  fix: #25600

  this allows to unload the GUI part of the interface without destroying the
  windows that may still be used by the vout window part.

  the variable was no longer initialized properly as it was stored
  in a "C" structure and there was no reason to store this variable in
  the module

  this will allow to unload the interface module without unloading Qt in a
  further patch.

  the new structure is still a vlc object as we use it notably for logging
  capacity and to interact with vlc variables

  This is a preparatory commit

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It's finally time to use RAVU/FSRCNN(X)/NNEDI3/Anime4K in VLC.

Currently limited to only one shader, which isn't a huge limitation
seeing as you can just `cat` together as many shaders as you want to use
into one big file. But patches welcome(tm).

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Unfortunately the UI for loading these is a bit clunky as they're hidden
behind so many layers of menu and advanced options, plus the fact that
the new LUTs still only get applied on vout reinit.

But it's still a feature that a lot of users have requested heavily, so
supporting them at all is a good thing. The implementation is rather
straightforward even though the amount of #ifdef's are really getting on
my nerves.

Can somebody just time travel me into a future universe in which I can
make libplacebo v4 the minimum dependency?

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Cosmetic. Side note: I really, *really* hope this commit title breaks
something, somewhere.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This is redundant with the minimum version requirement being 1.7.

I sure can't wait until the next bump up to 1.29.0. All these ifdefs
keep reminding me of my failure to design a good API on my first try.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

`pl->ops->close` destroys the GPU instance, after which the swapchain is
undefined. Fix it by moving the swapchain destruction to `ops->close`
itself, where it can be done in the correct order.

(This also fixes a bug where, technically, the opengl instance attempted
destroying the swapchain while the context was not current on the
thread)

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Recent versions of libplacebo use `pl_frame.crop` instead of
`pl_render_target.dst_rect`, for which the latter is now merely a
fallback.

Unfortunately, `pl_render_target_from_swapchain` ends up setting the
former field to values based on the swapchain dimensions, so the values
we set in `dst_rect` accidentally ended up ignored. In retrospect, this
was caused by the upstream decision to make the new field override the
old field if both are present, and having that logic the other way
around would also have avoided this bug. Bite the bullet and make it
conditional on the PL_API_VER.

All that said - merely fixing this bug, however, exposed serious
shortcomings in the video placement logic, in particular the lack of
proper flipping support for OpenGL. Fix it by rewriting the video
placement logic completely, based on the observation that
`vout_display_PlacePicture` is a relatively cheap function to call.
There's no need to awkwardly cache it inside `sys`.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This field was left-over from an early API design, and never used for
anything in libplacebo. Recent versions have since deprecated it.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

New upstream feature. Simply needs to be exposed in the UI.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This has already been the default in most libplacebo versions, in that
`pl_color_map_default_params.tone_mapping_algo` was equal to this value.
Despite this, it was never exposed in the UI, meaning users could not
actually manually select it.

Update the string to make it clear that this is the intended/recommended
default.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Not really that important or useful, but they're supported upstream so
there's also no real reason not to expose them.

huangjieNT authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

fixes #25780

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

closes #25581

Fatih Uzunoğlu authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

intends to be a temporary solution for #25599, #25776.

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

As per the Clang documentation, some sanitizers
only work with position independent executables,
so it is implied already by the sanitizer flag:

> Non-position-independent executables are not supported.
> Therefore, the fsanitize=thread flag will cause Clang
> to act as though the -fPIE flag had been supplied if
> compiling without -fPIC, and as though the -pie flag
> had been supplied if linking an executable.

https://clang.llvm.org/docs/ThreadSanitizer.html#limitations

Martin Storsjö authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This fixes building with the very latest nightly of Clang.

>= Win10

refs #25794

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This currently deadlocks the vout and should be done in the vout
window properly anyway.