Filip Roséen authored 8 years ago and Thomas Guillem committed 8 years ago

:: Introduction
----------------------------------------------------------------------

When we are dealing with a flat playlist, a request to add children to
an item results in that item being deleted, and its children being
inserted into the parent of said item. This is done in order to not
introduce any nested levels in the tree.

What this further means is that /if/ the item that is effectivelly removed is
scheduled for playback prior to the removal, the playlist might try to play an
entity which does not exist anymore; which is problematic for several reasons.

Note: The problem does not exist when --playlist-tree is enabled since
      the item on which children should be attached is then preserved.

:: Solution
----------------------------------------------------------------------

The solution to the previously described problem is to "redirect" any
pending request that refers to the deleted entity, so that it instead
refers to its first child (if any).

closes #17183

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Filip Roséen authored 8 years ago and Thomas Guillem committed 8 years ago

The previous implementation caused leakage of the data-member in
question due to missing clean-up. The manual memory management is now
replaced by std::string.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Filip Roséen authored 8 years ago and Thomas Guillem committed 8 years ago

If we do not insert the given track into our maps of tracks, we would
previously not invoke es_format_Clean on the given fmt, which of
course would leak dynamically allocated members.

There was also an issue with assigning values to data-members that
would later be overwritten, of course directly causing dynamically
allocated data to be leaked.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

With seek support (Range, Content-Range, Accept-Ranges) already
removed, virtual hosting (Host) is the only HTTP 1.1 feature still used
here. Dropping HTTP 1.1 allows removing support for chunked transfer
encoding.

The Host header field is still sent as virtual hosting servers need it
and accept it regardless of the HTTP version.

This distinguishes unexpected error from regular end-of-stream.

recv_end is set in the immediately following function call.

Fix umul_ppmm definition.

disable asm because of invalid operand for inline asm constraint error.

(This fixes the transcode module video filter option in preferences, as
the two was forgotten.)

decoder_NewAudioBuffer expects samples while we gave bytes.

Fixes #17319

disable asm because of invalid operand for inline asm constraint error.

Remove -mno-ieee-fp CFLAGS

Because of broken text relocations.

Since this is the future default toolchain of the Android NDK.