Ilkka Ollakka authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

conditioned to avcodec version where is it added

Ilkka Ollakka authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Allows to have less conditions in code when adding new ch_layout use

with previous code, it only handled 6 channels

Previously it muxed channels in incorrect order.

Remove unneeded arrays and use already defined one in demuxer-side.

WAVE-mapping don't match AOUT_CHAN mapping, so simpler to use
AOUT_CHAN_* mapping than trying to check how get reordering work with
WAVE_*.

Tristan Matthews authored 1 year ago and Steve Lhomme committed 1 year ago

Notably:
- Fixed various segfaults and buffer overruns (CVE-2023-2804)
- Fixed an issue that caused the C Huffman encoder (which is not used by
  default on x86 and Arm CPUs) to read from uninitialized memory when
  attempting to transform a specially-crafted malformed arithmetic-coded
  JPEG source image into a baseline Huffman-coded JPEG destination image.

Release notes:
https://github.com/libjpeg-turbo/libjpeg-turbo/releases/tag/3.0.0

Fixes a warning when using the integer variable to store the HINSTANCE.

This code only makes sense when calling ShellExecuteW(), so we move the
code in the same ifdef section.

We build for Win7+, the function is always there.

And no need to define PROCESS_DEP_ENABLE. It's available in mingw-w64 since 4.0.

Or rather vlc_cxx_helpers.hpp earlier which often includes winsock.

Only needed once for Windows and once for OS/2.

Only needed a couple of times for Windows and once for OS/2.

vlc_charset includes windows.h which is supposed to be included *after*
winsock.h/winsock2.h.

vlc_charset includes windows.h which is supposed to be included *after*
winsock.h/winsock2.h.

_DECL_DLLMAIN is needed to get the signature of DllMain. But depending
whether windows.h is included the signature differs (WINAPI, HANDLE, etc).
This is only the case in mingw-w64. In the Windows SDK there's only the
definition without the fancy types.

We need to include process.h before windows.h so we have the same definition
as the Windows SDK.

_DECL_DLLMAIN is needed to get the signature of DllMain. But depending
whether windows.h is included the signature differs (WINAPI, HANDLE, etc).
This is only the case in mingw-w64. In the Windows SDK there's only the
definition without the fancy types.

We need to include process.h before windows.h so we have the same definition
as the Windows SDK.

It is sometimes included without vlc_common.h.

This would be needed if we were using the registry.

Code doing Windows specific calls need to do the include themselves.

We should not always include windows.h because it should not be included before
winsock headers.

vlc_fixups.h may include some header that define different things depending
on the WINAPI_FAMILY (processthreadsapi).

We don't use any VLC code in there, only a few standard headers.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

This fixes synchronization issues when 2 demuxers have a different time
base (like .ts + .srt for example).

Fixes #21999

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

Set the source normal time, but only send the event from the main
source.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

cf. 0c0a4d1d

It will be used to differentiate the master source (in = NULL) from the slave
ones.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

To match with the next commit.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

And fix the misleading comment. VLC_TICK_0 was already used in case of failure.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

Fixes #28187

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

Also avoid re-using the same vlc_smb2_op for several calls.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

Refs #28187

The pkg-config or cmake exports should be present.
It will also give us the proper include folder and defines.