Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

shell || nicely handles the commands on the other lines without escaping
the end of line, which provides better error message in case of error.
In addition, priority of operators is much more obvious since the []
test syntax provides a visible scope-like feeling.

Thomas Guillem authored 2 years ago and Felix Paul Kühne committed 2 years ago

Not sure when this regression happened on the libsmb2 side.
But setting the password to an empty string do enable anonymous login
now.

Instead of the legacy array.

Errors can also be reported via generic cbs, that will cause the
vlc_smb2_mainloop to abort. In that case, we should destroy the smb2
context to fix the issue mentioned by 924c9515

op->smb2 won't be used in case of error but it is cleaner like that.

No changes since this function is only checked for != 0 (for now).

So that the aout_filters keep a strong reference on the vout it created
in order to control it.

Only the visualisation aout filters need the clock for the vout (for
now).

Create one slave clock per visualisation aout filter instead of always
creating one for all visualisation aout filters.

In order to hold more variables per filter, cf. next commits.

Mehdi Sabwat authored 2 years ago and Felix Paul Kühne committed 2 years ago

ubsan is enabled in the contrib recipe :
https://bitbucket.org/mpyne/game-music-emu/src/b3d158a30492181fd7c38ef795c8d4dcfd77eaa9/CMakeLists.txt#lines-67

This will require vlc to be always built with ubsan and we don't want this in production.

Alexandre Janniaux authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

pl-output-hint is an integer variable, and it was leading to warnings
when compiling:

    ../../modules/video_output/libplacebo/display.c: In function 'UpdateColorspaceHint':
    ../../modules/video_output/libplacebo/display.c:499:5: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
      499 |     case OUTPUT_HDR10:
          |     ^~~~
    ../../modules/video_output/libplacebo/display.c:503:5: warning: case label value exceeds maximum value for type [-Wswitch-outside-range]
      503 |     case OUTPUT_HLG:
          |     ^~~~
    ../../modules/video_output/libplacebo/display.c:477:5: warning: switch condition has boolean value [-Wswitch-bool]
      477 |     switch (var_InheritBool(vd, "pl-output-hint")) {
          |     ^~~~~~

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Regression from 31f97cbe

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

GL_RED and GL_RG are available since OpenGL 3.0 and OpenGL ES 3.0, or
via OpenGL extensions.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Extract version check to a separate static inline function.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

The function opengl_interop_init() is now used only by interop_sw().

Move its implementation and remove the init() callback.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

This prepares further commits.

Romain Vimont authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Free the private instance on error.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

All interop modules reused the util function opengl_interop_init()
(written for the software interop) to initialize the textures properties
from the chroma.

However, the actual texture format may not always be deduced from the
chroma: only the interop implementations have the full knowledge of the
texture details.

Therefore, initialize texture properties directly from each interop
implementation.

Fixes #26735
Fixes #26769

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

This will allow to call this function from interop modules.

This function is currently called from opengl_interop_init_impl() (the
init function pointer), which will be removed (so this narrows the scope
of helpers code exposed to modules).

In the future, more work will be needed to also remove this function
pointer.

Romain Vimont authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

The interop determines the format (currently based on the chroma and the
existence of the extension "GL_ARB_texture_rg").

Store this format in the vlc_gl_format, so that the sampler doesn't have
to guess by performing the same checks.