Alexandre Janniaux authored 5 years ago and Marvin Scholz committed 5 years ago

These files are generated but never used by Qt. They prevent libtool in
VLC from using pkg-config files, which would lead to misconfiguration issues,
especially in cross-compilation build.

The create_libtool config option is currently only set for unix builds, but
setting -create_libtool in the .prf file will prevent every other qt contribs to
generate libtool files too.

Signed-off-by: Marvin Scholz <epirat07@gmail.com>

The chain can only have a different output than requestedoutput if a converter
was appended after the filter_chain_Reset() call.

Maybe later we can have a dummy decoder device for tests.

We can't use the context of the real source and it's a CPU chroma so we should
use NULL.

Either video_format_update had been called and it missed the filter creation
and didn't update it, so we create the chain before the decoder. Or it was
called after and this initialization was useless and reset afterwards.

Now the filter chain will always use a correct video format and don't try to
create a bogus one when the decoder is opening.

Needed for the test_modules_keystore success.

Used for SMB domains.

Needed for the test_modules_keystore success.

Specially since the keychain could store more informations that the search
query.

Needed for the test_modules_keystore success.

It is mandatory for smb:// for example.

Needed for the test_modules_keystore success.

No functional change.

Either because Reset() set the same input value or the we're using the same
value set by the previous AppendXXX().

Either because Reset() set the same input value or the we're using the same
value set by the previous AppendXXX().

Needed for the code cleaning in the next patches.

The last output format is always the format of the last filter. It doesn't
matter if it was allowed to change the format or not. It's either the filter
added or the "chain" filter added to compensate for the format change (should
be adjusted in push mode)

This is how filter_chain_GetFmtOut() is documented "last output format of the
last element in the filter chain" and how it's used.

If there's no filter yet, the output format is the one used to initialize the
filter chain (via filter_chain_Reset).

The filter chain itself doesn't automatically adapt the output format to the
requested output format, which is good for push.

Use the local variable set on the whole chain rather than the value set on each
filter.

Similar to the input video context variable.

This matches the previous iTunes support.

Johan Gunnarsson authored 5 years ago and Thomas Guillem committed 5 years ago

Make sure the dbg macro can't compile down to nothing, so it can be used in
if statements without braces.

codec/telx.c: In function ‘Decode’:
codec/telx.c:686:81: warning: suggest braces around empty body in an ‘if’
statement [-Wempty-body]
(long int)(p_sys->prev_pts+1500000)));
                                     ^

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Shared runners will pick up the builds now

A instance of VLCOpenBlockDeviceDescription was casted to NSDictionary leading to a runtime exception (#23091).

This patch addresses the problem and prevents future issues by setting the class on the arrays.

Zhao Zhili authored 5 years ago and Thomas Guillem committed 5 years ago

Documentation of the API doesn't guarantee any particular error code.

Suggested by Thomas Guillem

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

In order to notify the user if he should wait for the stopped event.

And improve the libvlc_media_player_stop_async documentation.

In order to notify the user if he should wait for the stopped event.

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

In case of error, the registry variable is clobbered by the goto from
error handling and is freed without a correct value.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Alexandre Janniaux authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Sean McGovern authored 5 years ago and Thomas Guillem committed 5 years ago

Signed-off-by: Thomas Guillem <thomas@gllm.fr>