We can only remove filters that were created by filter_chain_AppendInner().

It can be done with filter_chain_ForEach()if needed.

No need for a specific function in the core. filter_chain_ForEach() is already
use multiple times with `filter_chain` a few lines above.

It can be done with filter_chain_ForEach() if needed.

No need for a specific function in the core. filter_chain_ForEach() is already
use multiple times with `source_chain` a few lines above.

Martin Finkel authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Fixes Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_NSNumber", referenced from:
      objc-class-ref in libsamplebufferdisplay_plugin_la-VLCSampleBufferDisplay.o

CVE-2023-5217
https://crbug.com/1486441 (CVE-2023-5217)

It's never used as such. Only 4 masks existed and they have been replaced with
VLC_CODEC_BGRX, VLC_CODEC_XRGB, VLC_CODEC_XBGR and VLC_CODEC_RGBX.

So that code passing a chroma as a string ends up on the on the same chroma
layout.

We want to get rid of masks internally, we can't handle odd values, just like FFmpeg.

The mask in AVI correspond to the Little-Endian values we read.

The alpha mask tested is the full 32-bit mask and not just 0xFF which only
matched RGBA before dd73c3e0.

Only use RGB32 when there's a mask involved (BI_BITFIELDS).

It is used to signal that the internal format will be RGB+alpha
so use the proper value right away.

This corresponds to the VLC FourCC<->OpenGL format mapping in interop_sw.

It is used to signal that the internal format will be RGB+alpha
so use the proper value right away.

This corresponds to the VLC FourCC<->OpenGL format mapping in interop_sw.

We have the most common ones and we won't be able to convert them
otherwise.

We pass the mask verbatim so that's how the mask were interpreted so far.

It's never used as such. Only 2 masks existed and they have been replaced with
VLC_CODEC_RGB24 and VLC_CODEC_BGR24.

So that code passing a chroma as a string ends up on the on the same chroma
layout.

Using BI_BITFIELDS is only allowed for 16/32 bits. VLC always writes BI_RGB
and flips the bits to match it if necessary.

We have the most common ones and we won't be able to convert them
otherwise.

We pass the mask verbatim so that's how the mask were interpreted so far.

This is the format once the mask will be "fixed".

The RGB32/RGB24 masks are passed verbatim to VLC. So the same assumptions
we made on the masks were correct, regardless of endianness.

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

texture() should be used after GLSL 130 on OpenGL, and must be used
after GLSL 300 es on OpenGL ES.

Fixes #28369

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

The GLSL version will be used to generate the correct function names for
non-forward compatible functions.

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

Getting the shader source enable better debugging when an error happens.

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

The es_id string is not used in the RTP module, leading to:

    ../../modules/stream_out/rtp.c: In function ‘Add’:
    ../../modules/stream_out/rtp.c:920:83: warning: unused parameter ‘es_id’ [-Wunused-parameter]
      920 | static void *Add( sout_stream_t *p_stream, const es_format_t *p_fmt, const char * es_id )
          |                                                                      ~~~~~~~~~~~~~^~~~~

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

The alpha is not initialized for some chroma which were not using it.

    ../../modules/video_filter/blend.cpp: In function ‘void Blend(const {anonymous}::CPicture&, const {anonymous}::CPicture&, unsigned int, unsigned int, int) [with TDst = {anonymous}::CPictureYUVPlanar<short unsigned int, 1, 1, false, false>; TSrc = {anonymous}::CPictureRGBX<4>; TConvert = {anonymous}::compose<{anonymous}::convertBits<10, 8>, {anonymous}::convertRgbToYuv8>]’:
    ../../modules/video_filter/blend.cpp:542:32: warning: ‘spx.{anonymous}::CPixel::a’ may be used uninitialized [-Wmaybe-uninitialized]
      542 |             unsigned a = div255(alpha * spx.a);
          |                          ~~~~~~^~~~~~~~~~~~~~~
    ../../modules/video_filter/blend.cpp:537:20: note: ‘spx.{anonymous}::CPixel::a’ was declared here
      537 |             CPixel spx;
          |                    ^~~
    ../../modules/video_filter/blend.cpp: In function ‘void Blend(const {anonymous}::CPicture&, const {anonymous}::CPicture&, unsigned int, unsigned int, int) [with TDst = {anonymous}::CPictureYUVPlanar<short unsigned int, 1, 1, false, false>; TSrc = {anonymous}::CPictureRGBX<4>; TConvert = {anonymous}::compose<{anonymous}::convertBits<16, 8>, {anonymous}::convertRgbToYuv8>]’:
    ../../modules/video_filter/blend.cpp:542:32: warning: ‘spx.{anonymous}::CPixel::a’ may be used uninitialized [-Wmaybe-uninitialized]
      542 |             unsigned a = div255(alpha * spx.a);
          |                          ~~~~~~^~~~~~~~~~~~~~~
    ../../modules/video_filter/blend.cpp:537:20: note: ‘spx.{anonymous}::CPixel::a’ was declared here
      537 |             CPixel spx;
          |                    ^~~

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Fix warning:

    ../../modules/gui/ncurses.c: In function ‘DrawStats’:
    ../../modules/gui/ncurses.c:691:23: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
      691 |     for (int i = 0; i < item->es_vec.size ; i++) {
          |                       ^

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

Don't try to copy the whole frame to the jarray buffer but copy it chunk
by chunk (50ms max). Therefore, a same frame can now be used for more
than one java write.

This fixes the following error and abort when allocating a too big
jarray (likely when sending a lot of silence to catch up with a playback
way to early).

E VLC   : [9b14b710/138c] libvlc generic: jarray allocation failed
E VLC   : [9b14b710/138c] libvlc generic: Write failed: ERROR
F DEBUG : Abort message: 'art/runtime/java_vm_ext.cc:470] JNI DETECTED ERROR IN APPLICATION: JNI GetJavaVM called with pending exception java.lang.OutOfMemoryError: Failed to allocate a 99591132 byte allocation with 3792244 free bytes and 90MB until OOM'

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

It was only used with Android API 21 and 22 (Android 5.x).
Remove this code that behave differently than all other write methods
and that is not as tested as the others.

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 1 year ago

... otherwise match() does not work properly
when previous() is called.