Also match the semantics of both functions.

No effective functional or ABI changes.

(No functional changes.)

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The function does _not_ copy the data.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

With latest SDK, arm64 is returned as architecture name for aarch64
machine targets from Apple, which is not recognized by autoconf, and
breaks compilation of multiple contribs.

We still need to indicate that we want an arm64 SDK, but replace arm64
by aarch64 in build triplets until autoconf fixes this.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

As of c0f0d085, waiting on a condition
variable is no longer a cancellation point. So these cleanup handlers
no longer serve any purpose.

Martin Finkel authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

In LibVLC 3, passing a NULL media was supported. In LibVLC 4, it currently crashes.
Fixes videolan/vlc-unity#123

Zhao Zhili authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

refs #22391

Fatih Uzunoğlu authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This reverts commit 38a3fb64.

Fatih Uzunoğlu authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This reverts commit 1f4113bd.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

As defined in RFC2397.

Thomas Guillem authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

cf. https://developer.apple.com/library/archive/documentation/DeveloperTools/Conceptual/DynamicLibraries/100-Articles/DynamicLibraryUsageGuidelines.html#//apple_ref/doc/uid/TP40001928-SW12

"""
When the library name is a filename (that is, when it doesn’t include
directory names), the dynamic loader searches for the library in several
locations until it finds it, in the following order:

 - $LD_LIBRARY_PATH
 - $DYLD_LIBRARY_PATH
 - The process’s working directory
 - $DYLD_FALLBACK_LIBRARY_PATH

When the library name contains at least one directory name, that is,
when the name is a pathname (relative or fully qualified), the dynamic
loader searches for the library in the following order:

 - $DYLD_LIBRARY_PATH using the filename
 - The given pathname
 - $DYLD_FALLBACK_LIBRARY_PATH using the filename
 """

Conclusion: DYLD_LIBRARY_PATH on macOS behave like LD_LIBRARY_PATH on
Linux but LD_LIBRARY_PATH on macOS has a different behavior than
LD_LIBRARY_PATH on Linux, so DYLD_LIBRARY_PATH should be used on macOS.
Specially since we can't really control if the library name will include
a path or not (relative or absolute).

This does not make the live555 module dependent on libopus, just the helper
functions in opus_header.{c,h}

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

caused options to always be adjusted to value of 1 when saving prefs.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

"flat" is not in the choice list and is meaningless to the module, not
matching any of its known presets. it is thus equivalent to a default of
"none". (see `window_get_param()` in `modules/visualization/visual/window.c`
which describes this as falling back to "using rectangular window (i.e. no
window)").

it is a reasonable assumption that the author meant the default to be the
`"flattop"` choice, and just made a mistake here, however this is not
certain and the preference expressed in review was to preserve the existing
behaviour by switching to "none".

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

the lowercase "auto" default option value did not match the uppercase
"Auto" in the choice list.

option values should typically be lowercase. this fixes the mistake with
the case of the choice value, whilst maintaining backwards compatibility
with existing CLI usage and from saved settings files. this was the
clear preference for fixing this resulting from the MR discussion.

Lyndon Brown authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

(no functional change)

 - better prepare for the next commit where we need to support both "Auto"
   and "auto".
 - avoid multiple `strdup()`.
 - avoid avoidable string comparisons.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

NULL does not map to an entry in the choice list.

also, mark the choice labels for translation.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

-1 was not in the choice list.

this adds the missing choice list entry corresponding to the default.
i've made a guess at the right label and explanation to use based upon
what seems to be happening with a -1 value in `stereo_to_mono()` and
from bits of git history relating to it.

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

0 was not in the choice list.

it looks like 0 was interpreted by the code as the same as -1 via
`dvb_parse_transmit_mode()`, so not a big problem.