Alexandre Perraud authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

  Rename menu to more

Alexandre Perraud authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Signed-off-by: Alexandre Perraud <alexandre@videolan.org>

Each chained_filter_t is slightly bigger, for now.

The node storage corresponds to the next/prev on an element.
The filter_list storage corresponds to the head/tail of the list.

We can only remove filters that were created by filter_chain_AppendInner().

It can be done with filter_chain_ForEach()if needed.

No need for a specific function in the core. filter_chain_ForEach() is already
use multiple times with `filter_chain` a few lines above.

It can be done with filter_chain_ForEach() if needed.

No need for a specific function in the core. filter_chain_ForEach() is already
use multiple times with `source_chain` a few lines above.

Martin Finkel authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Fixes Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_NSNumber", referenced from:
      objc-class-ref in libsamplebufferdisplay_plugin_la-VLCSampleBufferDisplay.o

CVE-2023-5217
https://crbug.com/1486441 (CVE-2023-5217)

It's never used as such. Only 4 masks existed and they have been replaced with
VLC_CODEC_BGRX, VLC_CODEC_XRGB, VLC_CODEC_XBGR and VLC_CODEC_RGBX.

So that code passing a chroma as a string ends up on the on the same chroma
layout.

We want to get rid of masks internally, we can't handle odd values, just like FFmpeg.

The mask in AVI correspond to the Little-Endian values we read.

The alpha mask tested is the full 32-bit mask and not just 0xFF which only
matched RGBA before dd73c3e0.

Only use RGB32 when there's a mask involved (BI_BITFIELDS).

It is used to signal that the internal format will be RGB+alpha
so use the proper value right away.

This corresponds to the VLC FourCC<->OpenGL format mapping in interop_sw.

It is used to signal that the internal format will be RGB+alpha
so use the proper value right away.

This corresponds to the VLC FourCC<->OpenGL format mapping in interop_sw.

We have the most common ones and we won't be able to convert them
otherwise.

We pass the mask verbatim so that's how the mask were interpreted so far.

It's never used as such. Only 2 masks existed and they have been replaced with
VLC_CODEC_RGB24 and VLC_CODEC_BGR24.

So that code passing a chroma as a string ends up on the on the same chroma
layout.

Using BI_BITFIELDS is only allowed for 16/32 bits. VLC always writes BI_RGB
and flips the bits to match it if necessary.

We have the most common ones and we won't be able to convert them
otherwise.

We pass the mask verbatim so that's how the mask were interpreted so far.

This is the format once the mask will be "fixed".

The RGB32/RGB24 masks are passed verbatim to VLC. So the same assumptions
we made on the masks were correct, regardless of endianness.