Lyndon Brown authored 5 years ago and Hugo Beauzée-Luyssen committed 3 years ago

 - places helpful bounds on controls in gui prefs that prevent
   cycling out of range.
 - results in range hints being given in help output.
 - avoids unnecessary module code.

Lyndon Brown authored 5 years ago and Hugo Beauzée-Luyssen committed 3 years ago

and remove the range from the labels, which is unnecessary.

François Cartegnie authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

anti clockwise

dec->fmt_in.i_cat might be UNKNOWN_ES when the codec is not supported
leading to an output leak from DeleteDecoder() since the category
specific code is not reached.

Fixes #26271

Use the category from the i_cat argument instead of dec->fmt_in.i_cat

Refs #26271

François Cartegnie authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

also removes extradata requirement to set pf_process_block

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

out of date since 0d895d8e

Lyndon Brown authored 5 years ago and Jean-Baptiste Kempf committed 3 years ago

already done by the add_rgb() macro

Marvin Scholz authored 3 years ago and David committed 3 years ago

Changing the install name is no longer necessary since
0831e42e
and doing so breaks the ad-hoc code signing leading to a broken
bundle and pseudo-bundle on arm64 which requires ad-hoc signing.

Fix #26127

Marvin Scholz authored 3 years ago and David committed 3 years ago

The Frameworks folder was missing in the rpath, leading to Frameworks
like Sparkle requiring change of the install_name after it was built
instead of just using rpath properly.

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The implementation could read beyond the b string.

Reported by ASAN:

    $ ./vlc --opaaaaaaa
    …
    Error: Unknown option `--opaaaaaaa'
    =================================================================
    ==522294==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000022655 at pc 0x7f8b1793d73d bp 0x7ffe311de800 sp 0x7ffe311de7f8
    READ of size 1 at 0x602000022655 thread T0
        #0 0x7f8b1793d73c in jaro_inner ../../src/config/jaro_winkler.c:111
        #1 0x7f8b1793db7a in vlc_jaro_winkler ../../src/config/jaro_winkler.c:159

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The type ssize_t may contain either a non-negative integer or -1. It is
only guaranteed to support values in range [-1, SSIZE_MAX], so it should
not contain arbitrary negative values.

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

`p_sys->psz_base_url` is `free()`'d by `Close()` as used in the error path.

use of a temporary variable, as requested in review, fixes the problem.