In some cases the tarballs are corrupted. If the extraction of the tarball
fails the build will fail (or may use part of an old extraction).

The `-` was introduced in 5d2ed11e.

Jacob Martin authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

This fixes a misleading 'fatal error' message that appears when make
is invoked for contribs.

Since cppcheck only used stdout of $(CC) to begin with, suppressing
stderr in this manner should not change its overall behavior.

See a5b9278c.

Maxime Chapelet authored 2 years ago and Steve Lhomme committed 2 years ago

This kind of error occurred on darwin when shasum check attempt wat made on Qt contribs :
```
+ make fetch
grep -- " qtdeclarative-everywhere-src-5.15.1.tar.xz$" "../src/qtdeclarative/SHA512SUMS" && (cd ../tarballs && shasum -a 512 --check /dev/stdin) < "../src/qtdeclarative/SHA512SUMS"
193ec706b764330a2ae00614b13482b7586642f9cfd32458e8c975daa07ba25f0f9887de0918c4034f52f613b860677c09c46a3b7d07d4229446cfc0805bcccd qtdeclarative-everywhere-src-5.15.1.tar.xz
shasum: /dev/stdin: no properly formatted SHA checksum lines found
make: *** [.sum-qtdeclarative] Error 1
umxprime@umxprime-m1 ~ % shasum -a 512 /Users/umxprime/code/videolan/vlc/contrib/tarballs/qtdeclarative-everywhere-src-5.15.1.tar.xz
193ec706b764330a2ae00614b13482b7586642f9cfd32458e8c975daa07ba25f0f9887de0918c4034f52f613b860677c09c46a3b7d07d4229446cfc0805bcccd  /Users/umxprime/code/videolan/vlc/contrib/tarballs/qtdeclarative-everywhere-src-5.15.1.tar.xz
umxprime@umxprime-m1 ~ %
```
This was mainly due to a missing whitespace between the sum and the filename in the SHA512SUMS list

The CMAKE variable already sets it for all targets.

The 4x 12 bits packing is making the bitfield packing messy and incompatible
with (non)MS packing in dvdnav. In the end the structures are not read as
packed structures so we don't need to keep them packed.

Upstream patch proposed at videolan/libdvdread!42

David authored 2 years ago and David committed 2 years ago

On mac, we use libc++ instead of libstdc++. While the library is
actually build against libc++ already, the pkgconfig file still
hardcoded libstdc++ instead.

Refs #27262

David authored 2 years ago and David committed 2 years ago

This library links against libm, so it should be added into its
pkg-config file for static builds.

Refs #27262

David authored 2 years ago and David committed 2 years ago

The latest version of game-music-emu links against zlib if it is
available.

Refs #27262

Tristan Matthews authored 2 years ago and Steve Lhomme committed 2 years ago

Notable changes:
 - This release adds optimizations for Loongarch, adds support for vp8 in the
   real-time rate control library, upgrades GoogleTest to v1.11.0, updates
   libwebm to libwebm-1.0.0.28-20-g206d268, and includes numerous bug fixes.

Bug fixes:
 - Fix to a crash related to {vp8/vp9}_set_roi_map.
 - Fix to compiling failure with -Wformat-nonliteral.
 - Fix to integer overflow with vp9 with high resolution content.
 - Fix to AddNoiseTest failure with ARMv7.
 - Fix to libvpx Null-dereference READ in vp8.

Submitted here libdvdread!41

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

Clang 16 made implicit function pointer conversions in C an error
(which previously was only a warning).

This backports the following change from upstream gnulib
to the version of the files bundled in gettext:
https://git.savannah.gnu.org/cgit/gnulib.git/commit/lib/obstack.c?id=0cc39712803ade7b2d4b89c36b143dad72404063

This fixes errors like these:

    obstack.c:351:31: error: incompatible function pointer types initializing 'void (*)(void) __attribute__((noreturn))' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types]
    __attribute_noreturn__ void (*obstack_alloc_failed_handler) (void)
                                  ^

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

Clang 15 made "incompatible pointer to integer conversion" an error
instead of a plain warning. This fixes errors like these:

../src/vulkan/gpu_pass.c:208:59: error: incompatible integer to pointer conversion passing 'VkPipeline' (aka 'unsigned long long') to parameter of type 'const void *' [-Wint-conversion]
        vk_dev_callback(vk, (vk_cb) destroy_pipeline, vk, *out_pipe);
                                                          ^~~~~~~~~
../src/vulkan/command.h:36:52: note: passing argument to parameter 'arg' here
                     const void *priv, const void *arg);
                                                   ^
../src/vulkan/gpu_pass.c:209:19: error: incompatible pointer to integer conversion assigning to 'VkPipeline' (aka 'unsigned long long') from 'void *' [-Wint-conversion]
        *out_pipe = NULL;
                  ^ ~~~~

This backports
libplacebo@1d3ff4d4.

Martin Storsjö authored 2 years ago and Steve Lhomme committed 2 years ago

Clang 15 made "incompatible pointer to integer conversion" an error
instead of a plain warning. This fixes errors like these:

system/keys-win.c:257:13: error: incompatible pointer to integer conversion initializing 'HCRYPTHASH' (aka 'unsigned long') with an expression of type 'void *' [-Wint-conversion]
        HCRYPTHASH hHash = NULL;
                   ^       ~~~~

This backports
https://gitlab.com/gnutls/gnutls/-/commit/88d79b964d88730e316919d6ccd17ca0fe9b3244.

Hugo Beauzée-Luyssen authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

If libupnp is built without --enable-debug, debug is entirely
deactivated.
When debug is enabled, users are required to call UpnpInitLog to enable
logging, otherwise logs are dropped

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Since relocation issues are now fixed.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Since relocation issues are now fixed.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Since relocation issues are now fixed.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

ld: error: /home/tom/work/git/vlc-android/vlc/contrib/aarch64-linux-android/lib/libavcodec.a(videodsp.o):(function ff_prefetch_aarch64: .text+0x10): relocation R_AARCH64_CONDBR19 out of range: 13363404 is not in [-1048576, 1048575]; references ff_prefetch_aarch64
>>> referenced by videodsp.S:26 (libavcodec/aarch64/videodsp.S:26)
>>> defined in /home/tom/work/git/vlc-android/vlc/contrib/aarch64-linux-android/lib/libavcodec.a(videodsp.o)
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Backport an existing patch from the master branch.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Disable neon_asm since it rely on arm-linux-androideabi-as (removed in
NDK25).

Temporary commit.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

 - Fix Android build with NDK25
 - Fix va_list reuse
 - Add aribcc_renderer_set_merge_region_images()
 - Add aribcc_renderer_try_render()

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

I have absolutely no idea where "lgcc" is added between rav1e/cargo/cargo-c.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

It needs the same patch than appleos. Maybe we should check for
aarch64 instead.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

execinfo.h is present but not necessary the functions (backtrace())
since it depends on the configured ANDROID_API.

It's not a clean and "upstreamable" patch, but the execinfo code is gone
upstream, so this patch is only temporary.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Cross tools changed from ${ARCH}-linux-android${API}-${TOOL} to
llvm-${TOOL).

Example: aarch64-linux-android21-strings to llvm-strings.

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Lots of patches have been either fully or partially implemented, and
have thus been dropped or reworked.

For macOS, the "macosx" config file is no more; only "macosx-bigsur",
"macosx-catalina", and "macosx-no-openssl". "macosx-bigsur" has been
chosen as the config, and all the sed commands have been fixed to
account for multiple macosx* files.

The library now uses ifaddrs.h unless NO_GETIFADDRS is defined. For
Windows, ifaddrs.h doesn't exist and thus is always needed. For Android,
it is available since API level 24.

The library also uses OpenSSL unless NO_OPENSSL is defined. This is
added to LIVE_EXTRA_CFLAGS, and the pkg-config file.

Johannes Kauffmann authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

The currently used live555 version already includes this patch. It
hasn't been applied since 82977245.

Niklas Haas authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

No longer needed as a consequence of the glslang version requirement
being bumped to 10.x.x or higher.

Niklas Haas authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Glslang does not export a pkg-config file, so the need_pkg function
always fails. Fix it by checking the header explicitly, instead.

It was somewhat annoying to get this to work with a multi-line string. I
ended up resorting to explicit \n escape sequences to work around make
stripping newlines during shell expansion.

Niklas Haas authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Instead of piping in /dev/null, take the code to pipe from $(2). This
does not regress the existing usages, as passing an empty variable
expands to an empty file.

This allows it to take an extra include statement, or even a more
complicated preprocessor check.

Niklas Haas authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Bumping this allows us to drop some backwards-compatibility patches in
the libplacebo contribs, by ensuring that a proper versioned glslang is
always available.

Version 10 of glslang is the first release including the new style build
info header, and is therefore also the minimum dependency required by
newer glslang versions. It makes a natural candidate to start requiring.