vd->cfg is only used in the vout thread so we don't need a local copy. We don't
need to modify it either.

It's always vd->cfg available to the display module.

The passed pointer is always vd->cfg. No need to go through varargs for that.

It's always vd->cfg.

It's always vd->cfg.

It's only used to print the format info before the first picture is
displayed. After that the format is not needed anymore.

It may differ if we change the chroma of the local fmt before it's set on
vd->fmt.

At this stage the only difference betweeen vd->source and vd->fmt is the SAR.
Since this local picture is only use to copy planes, the SAR is never used.

It's possible that the original code is wrong as it doesn't take in account the
"kms-vlc-chroma" forced chroma that the core will assume is used.

No need to depend on the output format.

At this stage fmt is not even filled yet.

This will prevent display modules from modifying it anytime they want.
They can modify the format on open, RESET PICTURES and maybe later when a new
format is pushed.

The storage of the display video_format_t is in vout_display_priv_t.display_fmt.

This will prevent display modules from modifying it.

Only osys->source can be modified and sent to the display.

All the fields we use in this function comes from this structure.

Move the function after the vout_display_priv_t definition.

No functional changes.

Don't always show "Client error" when there's an error.

Don't always return "Client error" as error reason

This follows the same approach as oldhttp, and allows configuring the
web interface to use HTTPS.

Refs #19807

It may also be merged in the core, in vlc_picture_pool.h.

The pool can be reused to manage the lifecycle of a picture pool with (hardware)
surfaces that can be released easily in push.

The pictures coming out of the pool no longer have p_sys filled. They only
carry a video context with the relevant data.

When the pictures are released after the module is dead, the p_sys value may
still be needed.

Also merge nvdec_pool_Destroy() into nvdec_pool_Release() as it's only called
there.

Since we set the picture p_sys it will try to deallocate the value when the
picture is destroyed.

Regression from 855dbc02.

DanielGlaas authored 4 years ago and Thomas Guillem committed 4 years ago

In function *Filter, there already existed a TODO note that it needs to be
checked whether the feeds have items at all. As this can change with every
parsing of the URLs, this can only be done dynamically at that point in time
when the display is rendered.

The TODO note in the function comment of ParseUrls seems to be outdated as the
check for an non empty url string is already done in function CreateFilter() in
lines 263..268.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

DanielGlaas authored 4 years ago and Thomas Guillem committed 4 years ago

This fixes a bug in the printing of scrolling title. As long as the title was
scrolling, the first item title was printed twice. Once by the "%s : %s" format
and the second time in the while loop afterwards some lines later.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

DanielGlaas authored 4 years ago and Thomas Guillem committed 4 years ago

The RSS display string generation contained lot of code duplications. With this
commit, structures that are used several times are factored out to make the final
snprintf() statements - which write the text into the marquee buffer - better
readable.

Signed-off-by: Thomas Guillem <thomas@gllm.fr>

refs #25035

webvtt_css_family_fallback_mono.mkv
with forced non zero background
32% less instr for RGBA/YUVA

We need to evaluate it on startup.

We need to evaluate it on startup.

The value read for VOUT_CROP_RATIO should be applied to vout_SetDisplayCrop()
not the source aspect ratio.

vout_SetDisplayAspect() always used "source.dar".

Regression introduced in 4563df98.

This is a regression from 3.0 where the AR is always applied, no matter the
cropping value.

In 3.0 the aspect ratio is applied before handling the crop, so we do the same.
https://code.videolan.org/videolan/vlc-3.0/-/blob/master/src/video_output/display.c#L866

And related internal variable/functions.

It cannot happen as no VOUT_DISPLAY_CHANGE_xxx can fail anymore. They're just
preparing the picture placement (and possibly moving the internal window).

We can still handle the D3DERR_DEVICENOTRESET case before displaying anything.

The http protocol accepts empty username. Other protocols may not accept it.
This will result on a fail of the login function, leaving the possibility to
try a new login.

Fixes #25074

typo introduced in 1964a189