CVPX -> CVPX chroma conversion filter is using HW-accelerated chroma
conversion (VTPixelTransfer) on MacOSX, which is also able to resize
pictures efficiently.

However, when generating pictures with VLC_CODEC_CVPX_BGRA as i_chroma,
the core will add the following conversion chain:

    CVPB (WxH) -> BGRA (WxH) -> I422 (WxH) -> I420 (W'xH')

Instead, by using this new filter with a higher priority, we can detect
that resize must be performed between CVPX buffers and directly convert
to the most suitable CVPX chroma type, leading to the following
conversion chain:

    CVPB (WxH) -> CVPI (W'xH') -> I420 (W'xH')

Which has the benefit to never use swscale while avoiding an additional
conversion, and transform the last conversion into only a memory
mapping.

...so that the function can be used in modules.

The parameter was not listed in the getopts possibilities.

Prince Gupta authored 4 years ago and Pierre Lamot committed 4 years ago

controls which require special column delegate are provided via separate
Component based property

Prince Gupta authored 4 years ago and Pierre Lamot committed 4 years ago

can be used to display image covers with play icons

Prince Gupta authored 4 years ago and Pierre Lamot committed 4 years ago

introduce property availableRowWidth in KeyNavigableTable which all views can use to calculate max columns

Ideally, the renderer should never clear at all, but clearing on Open()
is an unexpected drawing operation when initializing it.

It's important in particular on MacOSX in which the default framebuffer
is in a valid state only in drawing callbacks and Clear()-ing it leads
to invalid framebuffer operation errors in OpenGL.

When configuring the video converter filter chain, forward the video
context of the input picture into the chain. It allows starting the
correct conversion chain when the input picture has been made within a
video context (like VideoToolbox decoding) and need it to convert.

In particular, this commit fixes snapshot on MacOSX with VideoToolbox.

Romain Vimont authored 4 years ago and Alexandre Janniaux committed 4 years ago

The fields were used to move the dependency to OpenGL/GLES to runtime
and avoid opengl_tex_converter_t to be compiled twice on linux. Since
they were split into interop and samplers and that the interop doesn't
generate GLSL, the runtime dependency is not useful anymore.

It is not used for dynamic adaptation of shaders to the available GLSL
version too, so remove it for now.

Somehow revert of 524a003f

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

...instead of setting it, which might raise issues as soon as i_chroma
has been set instead of i_codec, and hide case in which i_codec has not
been set to the same value as i_chroma.

CVP* -> CVP* with the star equal to the same value is possible when
building a resize+chroma chain, but in the case of chroma only we don't
want to add additional steps.

In particular, it is used by filter_NewPicture and might raise issues
if it is incorrectly set.

The FPS filter is resampling the input source into the output source but
it only modifies metadata, so input chroma and input video context must
be used for output.

After a flush, i_first_render_host_time is reset to 0 and i_render_host_time
should not be touched since the playback has not started again yet. This caused
the i_first_render_host_time to be never setup.

Regression from f9fce135
Fixes #24876

removes double checks and move default selection check in fallback

split enforced & fallback cases, move fallback away from
cases leaves to sequential using autoselect flag