Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The implementation could read beyond the b string.

Reported by ASAN:

    $ ./vlc --opaaaaaaa
    …
    Error: Unknown option `--opaaaaaaa'
    =================================================================
    ==522294==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000022655 at pc 0x7f8b1793d73d bp 0x7ffe311de800 sp 0x7ffe311de7f8
    READ of size 1 at 0x602000022655 thread T0
        #0 0x7f8b1793d73c in jaro_inner ../../src/config/jaro_winkler.c:111
        #1 0x7f8b1793db7a in vlc_jaro_winkler ../../src/config/jaro_winkler.c:159

Romain Vimont authored 3 years ago and Romain Vimont committed 3 years ago

The type ssize_t may contain either a non-negative integer or -1. It is
only guaranteed to support values in range [-1, SSIZE_MAX], so it should
not contain arbitrary negative values.

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

`p_sys->psz_base_url` is `free()`'d by `Close()` as used in the error path.

use of a temporary variable, as requested in review, fixes the problem.

Dmitry Ilyin authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

non standard, mp4ra.org mapping

Felix Paul Kühne authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This correctly deploys custom values set through mobile apps

Zhao Zhili authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The first pass select track A, then the second pass select track B,
FragDemuxTrack(B) return EOF, the loop continue forever.

Attempt public key authentication using user specified path.
Or, if user specified key file path unset.
Attempt public key authentication by trying common default file paths:
 ~/.ssh/id_rsa
 ~/.ssh/id_ed25519
 ~/.ssh/id_dsa
 ~/.ssh/id_ecdsa

In both cases fall back to password autentication if key authetication
fails.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

home tab is designed to be displayed in no-medialibrary mode.
fix regression from 88f9ab3f