It works by just using Texture2D with the proper resource view. We don't use a
texture index anyway.

And rename D3D11_CompilePixelShader to D3D11_CompilePixelShaderBlob for
consistency.

LIBVLC_VIDEO_UPDATE_OUTPUT doesn't exist.

In some cases the decoder might ask for a decoder device that will use the
setup callback. But in the end it's not using the decoder device. Then the
display module is created, without knowing about that decoder device (via a
video context) and calls the setup callback again.

Unless the decoder device that is created in the vout is passed to the display
module, we need to allow those multiple calls per session.

Fix the D3D11 sample to take this in account. The D3D9 sample already takes
care of it.

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

This patch updates the style of play button according to the latest changes in the design.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

blendColors(text, bg, 0.6) does not provide enough contrast with textInactive

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

>From Qt 5.14.0, Qt::SplitBehavior enum is available and QString::split function causes warning when QString::SplitBehavior enum is used.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

This patch fixes the SortControl close animation which was not working when Qt 5.15 was used.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

This patch fixes the OverlayMenu open animation not working when Qt 5.15 is used.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

This patch fixes the race condition in the playlist regarding symmetric drop indication. The race condition was causing problems when Qt 5.15 was being used.

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

This is a quick fix for #25296 actually reverting the commit
a708c988, replacing the Hold/Release
lifecycle used there by an ad-hoc Hold/Release which actually defer the
actual release by blocking instead of releasing in the preparser thread.

Indeed, libvlc_media is holding the instance used to create it, though
it only needs it for preparsing. If the last reference of the media is
hold by the preparser, libvlc_media will be released by the preparser
thread and the libvlc_instance potentially released from there too.
Since killing the libvlc_instance will join the preparser thread, it
cannot be done from the preparser thread, or would lead to the failure
detailed in #25296. Written differently, only the final client should
make use of Hold/Release, directly through the adequate function or
indirectly through the creation of new objects.

In addition, a708c988 cannot just be
reverted as it was fixing cases where the libvlc_media_t object were
released before preparsing is finished, and the libvlc application
cannot just wait for the preparsing event to arrive since it must still
typically unlock the event manager and manage subitems.

Ideally, the libvlc_media would just not have a strong reference to the
libvlc instance, which would allow detaching the libvlc state from the
libvlccore state, but it cannot be done just yet, since the preparsing
API must be splitted from libvlc_media first.

Fix #25296

...and remove the obsolete comment, the cases have been fixed and should
be fixed if it happens again.

We don't need "proper event handling" as most errors are coming from
programmation errors, except in a few tests (like 16bit texture test)
which have been fixed already.

Zhao Zhili authored 4 years ago and Alexandre Janniaux committed 4 years ago

fmt_out.video.i_width/i_height are used in MediaCodec configure.
They are not set in --no-mediacodec-dr. Some devices require video
size to be non-zero. For example, Huawei P20 failed with the
following log:

I ACodec  : In onAllocateComponent create compenent, codec name: OMX.hisi.video.decoder.avc
E ACodec  : Wrong cropped rect (0, 0, 0, 0) vs. frame (0, 0)
E ACodec  : [OMX.hisi.video.decoder.avc] configureCodec returning error -22

E NdkMediaCodec: configure: err(-22), failed with format: AMessage(what = 'conf', target = 1) = {
E NdkMediaCodec:   int32_t encoder = 0
E NdkMediaCodec:   string mime = "video/avc"
E NdkMediaCodec:   int32_t max-input-size = 0
E NdkMediaCodec:   int32_t width = 0
E NdkMediaCodec:   int32_t height = 0
E NdkMediaCodec:   int32_t rotation-degrees = 0
E NdkMediaCodec: }

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Tanguy Dubroca authored 4 years ago and Alexandre Janniaux committed 4 years ago

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Fix the warning:

../../modules/demux/smooth/playlist/../../adaptive/playlist/BasePeriod.h:49:36: warning: 'getPeriodDuration' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
                virtual vlc_tick_t getPeriodDuration() const;
                                   ^

Fix the warning:

../../modules/demux/adaptive/logic/AbstractAdaptationLogic.h:51:45: warning: 'updateDownloadRate' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
                virtual void                updateDownloadRate     (const ID &, size_t, vlc_tick_t);
                                            ^

Fix warning:

../../modules/demux/dash/mp4/../mpd/../../adaptive/playlist/Segment.h:103:30: warning: 'debug' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
                virtual void debug(vlc_object_t *,int = 0) const;

The first element (initialized here by the = { 0 }) is an array, and
require braces. To avoid clunky braces, use the designated zero
initialization with a known simpler field.

With autoconf 2.70, the following warnings are emitted:

configure.ac:56: warning: AC_PROG_LEX without either yywrap or noyywrap is obsolete
./lib/autoconf/programs.m4:716: _AC_PROG_LEX is expanded from...
./lib/autoconf/programs.m4:709: AC_PROG_LEX is expanded from...
configure.ac:56: the top level

The documentation[1] of autoconf now states:

> Prior to Autoconf 2.70, AC_PROG_LEX did not take any arguments, and
> its behavior was different from either of the above possibilities: it
> would search for a library that defines yywrap, and would set LEXLIB
> to that library if it finds one. However, if a library that defines
> this function could not be found, LEXLIB would be left empty and LEX
> would not be reset. This behavior was due to a bug, but several
> packages came to depend on it, so AC_PROG_LEX still does this if
> neither the yywrap nor the noyywrap option is given.
>
> Usage of AC_PROG_LEX without choosing one of the yywrap or noyywrap
> options is deprecated. It is usually better to use noyywrap and define
> the yywrap function yourself, as this almost always renders the LEXLIB
> unnecessary.

The behaviour of the argument on autoconf < 2.70 is to ignore the
argument, so there are no issues with adding the option.

[1] https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/html_node/Particular-Programs.html#Particular-Programs

The -fobjc-arc was defined on CFLAGS whereas the only file compiled is
an objective-C file, thus it was unused. With the flag moved to
OBJCFLAGS, ARC is breaking the compilation because of a missing
__bridge cast.

The libci_filter_plugin_la_LDFLAGS must always contains the value of
$(AM_LDFLAGS) since it is at least defined once. Otherwise, automake
won't automatically define it to $(AM_LDFLAGS) $(LDFLAGS) and the plugin
won't be built correctly (ie, built as a convenience library because of
the lack of -rpath definition in LDFLAGS).

In addition, the frameworks were not correctly set for iOS, which was
not a problem in static build because there is no linkage, nor in
dynamic build before because the plugin was built as a convenience
library, thus not linked nor installed to the device with the bundle
script.

Since the frameworks are mostly common between MacOSX and iOS, just add
the corresponding OpenGL framework for each target, and define the other
frameworks out of any automake condition.