Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

We request kCVPixelFormatType_32BGRA which is BGRA, not RGB32.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

CMTime is **not** equivalent to vlc_tick_t. In particular, the timescale
doesn't match. So it should be converted before usage.

In addition, GET_TIME is supposed to return where the access is
currently reading, which should also match the timestamps of the output
frames from the access.

Fixes #26101

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

AVCaptureVideoDataOutputSampleBufferDelegate is implemented by
VLCAVDecompressedVideoOutput but wasn't signalled, leading to warnings
when compiling.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

ARC is not supported when storing NSObject in a structure. But it is
well-supported when storing a NSObject as (__bridge_retained void*) into
the p_sys until (__bridge_tranfer) releases it.

It highly simplify the whole handling of ARC objects and avoid using
CFRelease/CFRetain in the code, unifying with other Objective-C modules
like VLCVideoUIView or VLCOpenGLES2VideoView.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

...instead of using custom debug strings

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Set the framerate to 1 / framerate_base, avoiding the following warning
for a 30fps capture stream:

    rawvideo decoder warning: invalid frame rate 0/30000, using 25 fps
    instead

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Add a property that returns the NSImage that is currently used as
application icon for VLC. This is not always the same as
NSImageNameApplicationIcon due to easter eggs like the Christmas cone.

François Cartegnie authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

refs #26126

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

If a fallback chroma is used instead of the original chroma, we need to
trigger the insertion of a video converter to adapt to this new chroma.

Forgotten from c5ea9b76.

Regression from b79c2b22 which removed
the converter for RGB fallbacks and the following change in vout_helper
c5ea9b76 which reintroduce the
conversion without taking care of converters for RGB.

The proper way to avoid the insertion of converters is to add support
for the formats in the interop.c instead of using RGB fallbacks.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Checking only fallbacks means that VLC_CODEC_BGRA will typically be
reinterpreted as VLC_CODEC_RBG32 and will not display correctly.

It might be a regression from previous change refactoring the interop
code, and the resulting chroma issue is a regression from
b79c2b22 which removed the converter
for RGB fallbacks and the following change in vout_helper
c5ea9b76 which reintroduce the
conversion without taking care of converters for RGB.

Alexandre Janniaux authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The code will be common to the cases where we found a valid chroma for
the OpenGL interop.

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fixes 'Binding loop detected for property artistModel' errors

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fixup 6b96e6a0

Hugo Beauzée-Luyssen authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

When profiling the media library on a small samples folder, the calls to
EnsureUTF8 end up accounting for about 8% of the runtime (including
calls to vlc_towc)
By not always executing it, especially when the value is expected *not*
to be UTF8 but ascii, we end up spending only 0.04% of the time in
EnsureUTF8
This also saves useless calls when the value is to be dropped

Hugo Beauzée-Luyssen authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

It's used only once

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This reverts commit de9d757d.
This kludge is no longer necessary.

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This functionally reverts e124481d.
Fixes #26115.

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

This accepts a lone ':', which is not followed by two forward slashes
if the URL lacks a host part.

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

FD must be positive `int`.

The test in unsigned space is equivalent to  `fd < 0 || fd > INT_MAX`,
but:
 - it is faster and,
 - it will not cause impossible predicate warnings on platforms
   where `INT_MAX` equals `LONG_MAX`.

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

ref #25989

Prince Gupta authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

ref #25989

Alaric Senat authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Since the player became an opaque type, the object cast should not be
available publicly anymore.

Alaric Senat authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Use the player API instead of an opaque arbitrary vlc variable.

Alexandre Janniaux authored 4 years ago and Jean-Baptiste Kempf committed 3 years ago

This offscreen OpenGL implementation is available for all Darwin
platforms, either through EAGL for iOS/tvOS or through CGL for MacOSX.

Alexandre Janniaux authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Regression from 163fb486.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

No need to skip it with "forced" pictures otherwise the filter is no applied.