Rémi Denis-Courmont authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

It is currently unspecified what happens if the process does not exit
cleanly, so clarify that. Since this can actually happen, the
documentation ought to state what the result is to some extent.

There's no other object that can handle the configuration loading/saving.

We don't need to inherit the options, they can only be in the libvlc_int_t
object. var_GetNonEmptyString() is equivalent to var_InheritString() in that
case.

Martin Finkel authored 6 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Co-Authored-by: Thomas Guillem <thomas@gllm.fr>

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

If NULL, it continue to use default directories or the
"input-record-path" variable.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

My bad, libvlc_time_t is in ms. The timer API should use the sane unit
than libvlc_clock(), that is us in int64_t.

Also add missing vlc_tick_t <-> us conversion (no harm since 1 tick = 1
us for now).

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Any LibVLC users could request a timer from the player. This Media Player
timer has its own event API since:

 - It is only used to receive time update points:

 - The timer is not locked by the player lock. Indeed the player lock can be
   too "slow" (it can be recursive, it is used by the playlist, and is it held
   when sending all events). So it's not a good idea to hold this lock for
   every frame/sample updates.

 - The minimum delay between each updates can be configured: it avoids to flood
   the UI when playing a media file with very high fps or very low audio sample
   size.

The libvlc_media_player_time_point struct is used by timer update
callbacks. This public struct hold all the informations to interpolate a
time at a given date. It can be done with the
libvlc_media_player_time_point_interpolate() helper. That way, it is
now possible to get the last player time without holding any locks.

There is only one type of timer (for now):

libvlc_media_player_watch_time(): update are sent only when a frame or a
sample is outputted. Users of this timer should take into account that
the delay between each updates is not regular and can be up to 1seconds
(depending of the input). In that case, they should use their own timer
(from their mainloop) and use
libvlc_media_player_time_point_interpolate() to get the last time.

Niklas Haas authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

The window backend triggers a callback of the vout, and the vout
forwards this to the display using another callback. There are several
unfortunate layers of glue and indirections in the callchain. In
particular, we need to persist these ICC profile objects in some layer,
because of init order between windowing system and the window / vout
display module itself. I've chosen to add them to `vout_display_cfg_t`
because it fits well with the other "dynamic window state" properties in
there.

This approach also allows capable vouts to read directly from the
allocated ICC profile memory, minimizing the number of memcpys.

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

So it matches the other exports

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

The API is available on UWP builds and doesn't rely on dirent which may not be
compiled as UNICODE in mingw-w64.

The call to FindFirstFileExW already gets the first entry so we are always
ahead of one entry.

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

This will avoid some dirty casts between DIR and vlc_DIR on Windows.

The Windows handling could be done entirely without dirent.h which is not a
standard Windows API.

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

No functional changes.

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

To have a cleaner balance between the directory API calls.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Fix build on Android NDK25, where swab() is a static inline function
defined in <unistd.h>.

Thomas Guillem authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Asked by API users, more convenient than dropping !selected tracks
ourself.

Alexandre Janniaux authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

When compiling and not having writev/readv, the following error happens:

    make[2]: Entering directory '/home/janniaux/Projects/videolabs/vlc/build-tsan/compat'
      CC       strlcpy.lo
      CC       strnstr.lo
    In file included from ../config.h:952,
                     from ../../compat/strnstr.c:22:
    ../../include/vlc_fixups.h:232:1: error: unknown type name ‘ssize_t’; did you mean ‘size_t’?
      232 | ssize_t readv(int, const struct iovec *, int);
          | ^~~~~~~
          | size_t
    In file included from ../config.h:952,
                     from ../../compat/strlcpy.c:22:
    ../../include/vlc_fixups.h:232:1: error: unknown type name ‘ssize_t’; did you mean ‘size_t’?
      232 | ssize_t readv(int, const struct iovec *, int);
          | ^~~~~~~
          | size_t
    ../../include/vlc_fixups.h:237:1: error: unknown type name ‘ssize_t’; did you mean ‘size_t’?
      237 | ssize_t writev(int, const struct iovec *, int);
          | ^~~~~~~
          | size_t
    ../../include/vlc_fixups.h:237:1: error: unknown type name ‘ssize_t’; did you mean ‘size_t’?
      237 | ssize_t writev(int, const struct iovec *, int);
          | ^~~~~~~
          | size_t
    make[2]: *** [Makefile:1531: strnstr.lo] Error 1

Steve Lhomme authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

win64 has its own version of lfind() but assumes the 3rd parameter is an
unsigned.

This commit matches the #ifdef _WIN64 below this code which uses the Windows
version with the unsigned limit. The comment is copied from there as well.

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Some compilers don't like that.

Alaric Senat authored 3 years ago and Rémi Denis-Courmont committed 2 years ago

This is the first step for the `SetPCR` implementation in stream output.
These callbacks will allow stream outputs to have precise information
about the stream time advancement.

This patchset only provides the basis for now, a correct implementation
for all stream filters will come in a separate merge request.

Refs #27050

Co-authored-by: Alexandre Janniaux <ajanni@videolabs.io>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

This partially reverts commit 02293b1d.

Don't update the audio clock from this event but store the points in a
circular buffer. The play function will update the clock according to
these points.

Refs #27023

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

Refs #27023