Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

I included adaptation here of a few existing cases using a different
solution to the helper defines suggested in review.

Example warning:
```
../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp: In constructor 'SPrefsCatList::SPrefsCatList(qt_intf_t*, QWidget*)':
WARNING : ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:254: 40:  'void QSignalMapper::mapped(int)' is deprecated: Use QSignalMapper::mappedInt(int) instead [-Wdeprecated-declarations]
  254 |     connect( mapper, QOverload<int>::of(&QSignalMapper::mapped), this, &SPrefsCatList::switchPanel );
      |                      ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/QSignalMapper:1,
                 from ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:45:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qsignalmapper.h:71:10: note: declared here
   71 |     void mapped(int);
      |          ^~~~~~
```

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

```
../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp: In constructor 'SPrefsPanel::SPrefsPanel(qt_intf_t*, QWidget*, int)':
WARNING : ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:811: 52:  'void QButtonGroup::buttonClicked(int)' is deprecated: Use QButtonGroup::idClicked(int) instead [-Wdeprecated-declarations]
  811 |             connect( radioGroup, QOverload<int>::of(&QButtonGroup::buttonClicked),
      |                                  ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QButtonGroup:1,
                 from ../../modules/gui/qt/dialogs/preferences/simple_preferences.cpp:44:
/usr/include/x86_64-linux-gnu/qt5/QtWidgets/qbuttongroup.h:90:10: note: declared here
   90 |     void buttonClicked(int);
      |          ^~~~~~~~~~~~~
```

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This replaces almost all use of `SIGNAL()` and `SLOT()` with Qt5-style
strongly-typed connections. The `CONNECT()`, and `DCONNECT()` helpers
built around them have been removed.

Cases involving the `BUTTON_*` macros will be tackled in a separate
commit to improve clarity.

A few cases remain using `SIGNAL()` and `SLOT()` for now due to
complications that should be dealt with separately.

Fixes #26643

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It contains ComPtr, it should not be allocated with calloc()!

Also fixes a structure leak for each region quad.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

It has its own internal Win32 threads support. No need to rebuild this (heavy)
contrib when pthread changes.

No need to use winpthread from mingw either in the native protoc build when it
can use the Win32 threading API. And thus the codebase is the same in both
case.

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The values are not dynamic, so we can know the value during the filter open.

Niklas Haas authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

In libplacebo v4.192, specifying the tone mapping state object is no
longer optional. Failure to do this forces an internal fallback to a
fixed function hable shader.

The OpenMAX Development Layer seemingly never really happened, so this
module was never ever taken into use.

Only x86 still uses the flaky procfs parsing.

This was added over a decade ago, but ...

This is necessary for Linux-specific getauxval() and associated flags.
In this case, VLC needs AT_HWCAP (and probably AT_HWCAP2 going forward)
to detect CPU features on most architectures.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

vlc_modcap_cmp() expects pointers to vlc_modcap structures, not to
character string pointers.

Fixes #26642.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Search keys and tree entries are non-const.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This rewrites vlc_once() as a trivial wrapper for vlc_once_begin() and
vlc_once_complete().

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This supports one-time initialisation without callback, which is
somewhat more flexible and provides better type safety.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

At this point, high-definition RGBA is 64-bit format. Since the support
code is essentially already there in macro form, take it into use.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Planes may have different sample size (if NV12 or NV21 chroma), but the
transform is always the same, so per-plane callbacks are no longer
necessary.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Rotations and anti-transposition are defined as the composition of
horizontal flip or transposition with one or two "free" vertical flips
(i.e. negated stride). The 3 functions, for 8-, 16- and 32-bit samples
were essentially identical.

This takes them out of the transforms macro and merge the function.
With this size-specific functions and function pointers remain only for
horizontal flip and transposition. This reduces the code size, and more
importantly simplifies writing SIMD-optimised transforms.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This saves the order of magnitude of the sample byte size for each
plane. This will be used in later changes.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

No functional changes.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Check for unsupported scenarii before allocating memory.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This was never actually implemented.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This requires MacOS 10.5 or less, which was dropped in VLC 2.1.0.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Omitted from 9b8944c7.