- Jul 25, 2018
-
-
Thomas Guillem authored
Fixes #20885
-
Thomas Guillem authored
-
- Jul 24, 2018
-
-
François Cartegnie authored
This reverts commit ce363882. Not useless as used by functions in evaluation.. Broke DTV.
-
François Cartegnie authored
Triggers duplicate packets on some boundaries and artifacts. There's no way to tell if that's a real discontinuity or duplicate packet. At least we can discard false positives for duplicates.
-
François Cartegnie authored
-
Jean-Baptiste Kempf authored
This could happen on a corrupted stream, there is already a msg_Err and a failure for the core...
-
François Cartegnie authored
-
In order for us to support streaming to more than one chromecast using the same instance of libvlc (as through VLM), and with the same options for the httpd, we will need to have a unique identifier for each output. These changes generates a random path upon initialization of the relevant object, while also incorporating the current tick. There is an extremely slim chance that two chromecast souts would try to create the http bindings at the exact same time, but vlc_tick_now + a random identifier is a "better safe than sorry" implementation. In order to really dive down in the "better safe than sorry"-category, we try three times before giving up. fixes: #20380 fixes: #20890 Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
Both the path and port are available upon construction of the ChromecastCommuncation, they also do not change during the lifetime of the object. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
These changes includes usage of the relevant stream info helpers. It also adds an additional slash to the art URI, so that items can be accessed through "/chromecast/unique/unique/art/$ID", where $ID denotes the art-id as used in the implementation, instead of "[...]/art$ID". This is not a change in behavior as the URIs passed to the device is per session, and the device is given notice of the URI by us, it does not probe it implicitly. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
The previous implementation had hard-coded paths in several places, and each place relied on other relevant part using the same paths. From a maintainability perspective this is a mess, and bound to fail one way or another. These changes introduce helper-functions that can be called in places where the values are needed, effectively adding a layer of protection to maintainability issues by making sure everything is using the same values. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
The relevant code suffers from some immediate flaws, with no real gain: 1. The implicit http-bind from within sout_StreamChainNew has a high chance of colliding with other things in vlc (most notably a web interface). 2. It does not bind to the same httpd URI as is later used in the module, causing the check to signal false security in terms of usability. 3. As the sout is created only to immediately be shut down, other attempts (not made within the module) to create a relevant sout will race with this "check". Just because we succeed in Open does not mean that we will succeed later on, nor does failure guarantee further failed attempts. 4. There is no reason for us to check if a muxer is available at this stage as it: a) Does not send any data down the pipe, meaning that we might fail anyway when we actually get started due to, as an example, codec issues. b) Does not match what might actually be used (avformat/webm or avformat/mkv is selected further into the implementation) c) Is the wrong way of checking things. If we want to make sure that an sout is created before some other work is done, we should create an sout which we then use, _before_, other work is done. refs: #20380 Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
François Cartegnie authored
adds default -1/auto/invalid value for align. we had no way to tell if user specified something.
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
The previous implementation would not reset the read position if someone tried to seek outside the current buffer, causing the module to signal EOF on subsequent reads, which is of course false. These changes makes sure that we do our best to reset back to the original position, preventing a premature EOF. Close #20540 Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
In order for us to start over, such as a failed attempt of dumb-seeking, we must reset the state of our extractor as if we just opened the file. This helper accomplishes that while also making sure that all associated variables are back in a proper state. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
qwindows.a will only be present if building for windows, and the other commands are irrelevant if we are not. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
François Cartegnie authored
-
François Cartegnie authored
-
Thomas Guillem authored
This is not needed since VideoToolboxNeedsToRestartH* was added.
-
Thomas Guillem authored
This fixes BadDataErr when playing streams in the middle (when video track is disabled and enabled). This happened a lot when running chromecast in the middle of playback. Furthermore, a BadDataErr from the decoder, while the videotoolbox encoder is running cause random crashes.
-
Thomas Guillem authored
-
Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
Thomas Guillem authored
This obviously lead to severe crashes. Regression from 6b96ade7
-
Thomas Guillem authored
Fixes CID #1438097 (false positive)
-
- Jul 23, 2018
-
-
Steve Lhomme authored
When increasing we go from 0 to pitch-1 but when decreasing we were going from pitch to 1.
-
François Cartegnie authored
-
Thomas Guillem authored
It was used to get the es id added by an input slave in order to enable it. There is no real clean way to enable a future es_out_id from a future input slave. The dumb way to do it is to listen to ES events and recover the last id (what this commit is doing).
-
Thomas Guillem authored
-
Due to d3c6ad0b, pictures may have different chroma. All frames are dropped. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
The crash was due to the previous imlpementation inaccurate assumptions regarding the input-data, more specifically it assumed that only one bookmarks= option would be present (something which is not guaranteed to be true). These changes also fixes a premature release of the input_item_t's mutex. Signed-off-by:
Thomas Guillem <thomas@gllm.fr>
-
Signed-off-by:
Hugo Beauzée-Luyssen <hugo@beauzee.fr>
-
- Jul 22, 2018
-
-
By negating the protective if-condition we can get rid of one layer of indentation. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-
All of the handling in terms of ACTIONID_NAV_{LEFT,RIGHT,UP,DOWN} have the same logic, besides what button they affect. A new helper, ProcessNavAction, has been introduced to avoid code-duplication. Signed-off-by:
Jean-Baptiste Kempf <jb@videolan.org>
-