Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Check for unsupported scenarii before allocating memory.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This was never actually implemented.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

This requires MacOS 10.5 or less, which was dropped in VLC 2.1.0.

Rémi Denis-Courmont authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

Omitted from 9b8944c7.

YoutubeDL is pretty much dead.
Fixes #26206.

This is invalid in C++.

Steve Lhomme authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

As specified in the format [1].

> If the DisplayUnit of the same TrackEntry is 0, then the default value for
> DisplayWidth is equal toPixelWidth - PixelCropLeft - PixelCropRight,
> else there is no default value.

[1] https://www.ietf.org/archive/id/draft-ietf-cellar-matroska-08.html#section-8.1.4.1.31.11

Steve Lhomme authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

We can apply the SAR once we know the cropped pixels dimensions and the actual
display dimension requested.

Apply the DAR when DisplayUnit is 3 [1].

[1] https://www.ietf.org/archive/id/draft-ietf-cellar-matroska-08.html#name-displayunit-element

Steve Lhomme authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

We can also apply the pixel cropping no matter what, if the value is 0 it will
have no side effect.

Ref. #26501

Benjamin Arnaud authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

When calling StackView.replace() together with custom properties we have to provide
generic types (var, int, string). Otherwise we get 'casting' issues when using
a specific one (like MLItemId). This was causing invalid values to be restored
when navigating between the QML MediaLibrary views.

fix #26629

Co-authored-by: Prince Gupta <guptaprince8832@gmail.com>

Lyndon Brown authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Loop revised to c11 style rather than just dropping the unnecessary `t;`
upon request by Alexandre in review.

```
../../modules/demux/mkv/matroska_segment_parse.cpp: In member function 'void mkv::matroska_segment_c::ParseTracks(libmatroska::KaxTracks*)':
WARNING : ../../modules/demux/mkv/matroska_segment_parse.cpp:1102: 10:  statement has no effect [-Wunused-value]
 1102 |     for (t; t != matroska_segment_c::tracks.end(); ++t)
      |          ^
```

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Fixes #26635.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Co-authored-by: Benjamin Arnaud <benjamin.arnaud@videolabs.io>

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Co-authored-by: Benjamin Arnaud <benjamin.arnaud@videolabs.io>

Alaric Senat authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

`ops` being NULL is a possibility when encoder loading failed.

Fixes #26624

Thomas Guillem authored 3 years ago and Rémi Denis-Courmont committed 3 years ago

Fixes GeoVision video playback via the avi demuxer.

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The update/clear icon-based button here gives no indication that it has
the focus if you tab to it via keyboard navigation. Switching the button
type from `QPushButton` to `QToolButton` fixes this.

Note that the similar button in the sync tab of the effects dialog is of
type `QToolButton` and did not exhibit the problem.

(Non-functional change; no other change in appearance).

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

(No functional change).

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

The effects dialog sync tab widget should belong to the main tab widget,
not the secondary tab widget within the video tab, which makes no sense.

(No functional change).

Lyndon Brown authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

If you used the `Tab` key to navigate between controls within the
synchronization tab of the effects dialog, once you landed upon the refresh
button (the circular icon, top-right) navigation got stuck, refusing to
jump to a new control.

I tracked down the cause to be related to the fact that the next control in
the tab list will be the 'apply' button, but in a tab change event handler
we hide the apply button for the sync tab. This seems to confuse Qt, though
navigating in reverse (`Shift`+`Tab`) works fine. Flipping the focus policy
of the button depending upon whether or not it is hidden works as a fix.

Fixes #25923.