This image contains a prebuilt protobuf-compiler

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

We no longer use/support it in 4.0

Steve Lhomme authored 3 years ago and Hugo Beauzée-Luyssen committed 3 years ago

We no longer force/use pthreadGC2 in 4.0

Rémi Denis-Courmont authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

As brackets are separators only within the authority part, thier use
within (or on the edges of) the path does not create any ambiguity.

Fixes #26092.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The `next_system_pts` has nothing to do with the displayed.next picture. It's
the date of the displayed.current picture in system time.

The `date_next` also has nothing to do with the displayed.next picture. It's
the system date where we should initiate the prepare() for displayed.next.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

mutex_cleanup_push() and vlc_cleanup_pop() are not available in C++.
All we want is to tell the feeder thread to exit when it's idle.

The condition will be triggered when:
* a frame has completed
* the maxdelay to wait before scheduling a new frame has been reached
* the local thread cancel has been requested

We no longer use the cancellation API which is not available in C++.

The convertion will incur a cost which we don't want to pay since the
art needs to be encoded in base64, which doesn't include anything
outside of ASCII

VLC_EGENERIC has no equivalent in <errno.h>, so it should not alias any
<errno.h> value. This maps it to INT_MIN. It works because -INT_MIN equals
INT_MAX + 1, which is out of range of `int`. As a reminder codes in
<errno.h> are positive integers.

The convoluted definition is to avoid pulling <limits.h> into
<vlc_common.h> and from there all over the code base.

Not exact (and mismatched) defines.

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

fix: #26043

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

the limit no longer exists in the medialibrary

Pierre Lamot authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

the active focus handler of the local banner was triggered when the search box
got focus through a shortcut and force the focus on another component.

Making the local banner a control fixes the issue. The initial reason of the
change was to be able to check the focus reason in the focus handler, but this
seems unnecessary.

Johannes Kauffmann authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Previously, the volume and mute properties would read their default
values (0 and false respectively) since neither Open() or Start()
would call aout_{Volume,Mute}Report by themselves.
Now, the initial volume and mute status are read during Start(), which
means that setting the volume should work after the first
volume_changed event is received by a libvlc consumer.

Partial workaround for #26032.

As a result, reporting the volume level after (un)muting is no longer
necessary (d104faec).

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The same variable may be set, but we should use the one from the tracks.

Only genre and description may not be set per track. The other are written
properly on each track.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The names are similar to the ones found in Vorbis.

http://age.hobba.nl/audio/mirroredpages/ogg-tagging.html

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The names are similar to the ones found in Vorbis.

http://age.hobba.nl/audio/mirroredpages/ogg-tagging.html

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Something some empty values are set in the file.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

CDTEXT_MAX_TRACKS is 0x7F, so we can never get more, since the number of track
is already read using 0x7f. The real check is the upper bits check in the next
line (extension flag).

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

It will end up returning -1 but we can avoid going further for no reason.

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

We know we want to read 4 bytes exactly, which always higher than
MINIMUM_CDROM_READ_TOC_EX_SIZE (2).

Marvin Scholz authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Found with lgtm.com

Marvin Scholz authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Found with lgtm.com

Steve Lhomme authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

And make CMediaBuffer a IMediaBuffer with extra data.

Prince Gupta authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

only try to get nativeResource for window with valid handle

fixes "nativeResourceForWindow: 'handle' requested for null window or
window without handle" warnings at startup and closing