Pierre Lamot authored 3 years ago and Rémi Denis-Courmont committed 2 years ago

volume slide was no longer customisable

Pierre Lamot authored 3 years ago and Rémi Denis-Courmont committed 2 years ago

gradient was no longer used in design

Steve Lhomme authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

In may come in packetized form but the extra data are not given (from raw OBU
files).

Felix Paul Kühne authored 2 years ago and Rémi Denis-Courmont committed 2 years ago

The SMB modules cannot do the Bonjour lookup, so resolve the hostname
and forward the first IP, which typically is the preferred value.

This fixes vlc-ios#1319

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Reset the meter fmt to NULL when destroying the stream.

WARNING: ThreadSanitizer: heap-use-after-free (pid=45968)
  Read of size 1 at 0x7b4400019fdc by main thread:
    #0 aout_filter_Create ../../src/audio_output/filters.c:56 (libvlccore.so.9+0xa4945)
    #1 vlc_audio_meter_CreatePluginFilter ../../src/audio_output/meter.c:83 (libvlccore.so.9+0xa7074)
    #2 vlc_audio_meter_AddPlugin ../../src/audio_output/meter.c:108 (libvlccore.so.9+0xa71df)
    #3 aout_AddMeterPlugin ../../src/audio_output/output.c:1008 (libvlccore.so.9+0xaa088)
    #4 vlc_player_AddMetadataLoudnessListener ../../src/player/metadata.c:106 (libvlccore.so.9+0x98f93)
    #5 vlc_player_AddMetadataListener ../../src/player/metadata.c:181 (libvlccore.so.9+0x990bc)
    #6 test_audio_loudness_meter ../../test/src/player/player.c:2842 (test_src_player+0x5db2)
    #7 main ../../test/src/player/player.c:2961 (test_src_player+0xa9fa)

  Previous write of size 8 at 0x7b4400019fd8 by main thread:
    #0 free ../../../../src/libsanitizer/tsan/tsan_interceptors_posix.cpp:711 (libtsan.so.0+0x368a8)
    #1 vlc_player_track_priv_Delete ../../src/player/track.c:145 (libvlccore.so.9+0x94d60)
    #2 vlc_player_track_Delete ../../src/player/track.c:153 (libvlccore.so.9+0x94d7d)
    #3 ctx_reset ../../test/src/player/player.c:630 (test_src_player+0x484d)
    #4 test_end ../../test/src/player/player.c:1044 (test_src_player+0x5696)
    #5 test_es_selection_override ../../test/src/player/player.c:2913 (test_src_player+0x5b18)
    #6 main ../../test/src/player/player.c:2960 (test_src_player+0xa9f2)

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Lock fmt on read/write since it's written from the DecoderThread and
read anywhere (when creating a meter module from the player).

Romain Vimont authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Since commit 66e86e15, m_sourceSize is
never written, and no scaling must be applied.

This makes hoverMoveEvent() consistent with mouseMoveEvent(), which did
not apply any scaling.

Fixes #25385
Fixes #26799

APEv1 should have flags set to 0 (no footer), but let's not assume writers set
this properly.

https://mutagen-specs.readthedocs.io/en/latest/apev2/apev2.html

The extra 32 octets are only needed if a certain flag is set.

The size constraint is on the max amount that GetDWLE can return which doesn't
have any limit in the specs:
https://mutagen-specs.readthedocs.io/en/latest/apev2/apev2.html

A different check on the size we actually allow to keep (MAX_TAG_SIZE) in
memory is done elsewhere and doesn't belong in the header size reporter.

vlc_stream_Read() cannot return properly more than that.

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

It requires the free AV1 extension to be installed.

https://www.microsoft.com/en-us/p/av1-video-extension/9mvzqvxjbq9v

Steve Lhomme authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Modern DXVA decoders are not tied to a single Texture with all slices.

We have to allocate the Shader Resource View (SRV) each time.

Oneric authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Due to a quirk in the ASS format some tags do depend on the exact
storage size of the video not just the pixel aspect ratio, so tell
libass via ass_set_storage_size to achieve correct rendering.

For ASS, storage size refers to the size the video is encoded in (stored
at) with codec-level crop applied; further transforms like e.g.
anamorphic de-squeezing or container-level crop must not be applied.
This matches the used fmt_src values despite them being named
visible_{width,height} and the existing PAR calculation already relies
on this.

Fixes videolan/vlc#26634

Prince Gupta authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

delegate History update to the parent, instead of directly handling it
in PageLoader.

Alaric Senat authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

The encoder is now fully deallocated by `vlc_encoder_Destroy` below.

Alaric Senat authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Prefer clearing object resources instead of calling `module_unneed`
which isn't set in all cases.

Thomas Guillem authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Leftover from b92f4f50