William Ung authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

Co-authored-by: Shaleen Jain <shaleen@jain.sh>

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Shaleen Jain authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

UPNP SDK functions cannot be called from the registered
callback so there is no point in passing an instance of
upnp instance to the callback as a user data.

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Shaleen Jain authored 6 years ago and Jean-Baptiste Kempf committed 6 years ago

Header files should be self-contained and should not have
to adhere to special conditions or include order to include the header.
Also add a header guard

Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

This keeps track of the underlying memory allocation, and makes room
for non-anonymous memory allocation.

p_sys will be used for software pictures too.

MODULE_NAME is only used for static builds:

Here is an example:

for codec/liba52_plugin_la-a52.lo
 MODULE_STRING=a52
 MODULE_NAME=codec_a52

for packetizer/a52.lo
 MODULE_STRING=a52
 MODULE_NAME=packetizer_a52

This patch will fix conflicts with the 2 vlc_entry__a52 symbols (that will now
be vlc_entry__codec_a52 and vlc_entry__packetize_a52).

On Android, we used objcopy to rename these symbols, but this tool is not
availaible on iOS toolchain.

An event must be queued into the event loop so that the stop flag
can be executed and the main loop can be actually stopped.

If we we would have called the super implementation of this method
this would be not needed. But due to our custom deinit code in
Close, we do not call super, but instead do manual cleanup there.

closes #21369

It's never used, even the picture is rarely used.

Steve Lhomme authored 6 years ago and Thomas Guillem committed 6 years ago

For asynchronous displays it may be better to schedule the display
in Prepare() and nothing is done in Display().

All the modules have to do this boilerplate code, some potentially not
releasing the subpicture.
Only VDPAU and MMAL hold a reference on the picture after Display is called.

Niklas Haas authored 6 years ago and Tristan Matthews committed 6 years ago

This doesn't break anything since the typo was reproduced everywhere
it's used, but it's still worth fixing.

or if a metadata update is found

It doesn't export anything that is usable by modules.

As specified in the other controls

Not the actual primaries/luminance corresponding to the colorspace/transfer in
use.