cannot pass on truncated end

(cherry picked from commit 1db4d294)

(cherry picked from commit 1c03970b)

(cherry picked from commit 54ffcdec)

(cherry picked from commit 1cd8422a)

(cherry picked from commit 6aeaeb61)

(cherry picked from commit d2312650)

(cherry picked from commit 599757d9)

Alex Chernyakov authored 2 years ago and Steve Lhomme committed 2 years ago

In exec_DataSharedMem() memory is allocated via the call to picture_New().
This memory is correctly freed via picture_Release() if an error occurs,
but if no error occurs and the function proceeds normally, the memory is
never freed. When the DataSharedMem routine is called repeatedly (e.g.,
to update a picture continuously), this leak accumulates very quickly.

(cherry picked from commit 41c1d1a9)

In UWP apps (and now libvlc) it was possible to set the swapchain and D3D
context to use for the rendering, via the command-line.

This sample app uses this functionality in a basic win32 app.

No functional changes.

It's still the only supported mode in UWP 3.0 builds.

No functional changes.

Since there is not GPU callbacks in 3.0 this allows using a custom D3D11 render
target with regular libvlc as we can do in UWP libvlc.

Co-authored-by: Martin Finkel <me@martinfinkel.com>

We can do the same in standard C.

Marvin Scholz authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

In some rare cases psz_text can be NULL, which would end up being
passed to strlen, causing a crash.

Fix CD 524d077a-d613-4f2f-85b1-2a2af0747888

(cherry picked from commit 2322d55d)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

(cherry picked from commit d0b87b53)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

refs #27164

(cherry picked from commit 9ba23e7d)
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>

Thomas Guillem authored 2 years ago and Steve Lhomme committed 2 years ago

Like it's done in other part of the GetVaProfile() function.

For the current issue, the extra data is set midstream by lavc (and not
by our mkv demux).

The 4.0 branch does not need this patch since the VAAPI initialisation
is done by lavc.

Thanks Steve for the hint.

Co-authored-by: Steve Lhomme <robux4@ycbcr.xyz>

Fixes #27163

While Darwin implements fstatvfs, the statvfs structures f_flag
field is only defined to contain two flags, ST_RDONLY and ST_NOSUID.
So the check for MNT_LOCAL would always be false, reporting all files
as non-local.

To mitigate that, on Darwin we can just use fstatfs and check
statfs.f_flags for MNT_LOCAL.

(cherry picked from commit 132ef662)
Signed-off-by: Marvin Scholz <epirat07@gmail.com>

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

prevents blind seek to start of stream as granule is never read

(cherry picked from commit cd79514d)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit 125a46cc)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit ac81e531)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit fc94fb4e)
(cherry picked from commit 6a995af6)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit 9a42c531)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit 3783f868)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit f3228de7)

François Cartegnie authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit 22bd3d8b)

Johannes Kauffmann authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

The currently used live555 version already includes this patch. It
hasn't been applied since 82977245.

(cherry picked from commit d882aa87)

See #26921

(cherry picked from commit aecaaec7)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Tristan Matthews authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

(cherry picked from commit 989a6ac8)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Tristan Matthews authored 5 years ago and Jean-Baptiste Kempf committed 2 years ago

(cherry picked from commit 01297f16)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Tristan Matthews authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

(cherry picked from commit 8ded42d7)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Multiple OOB-read, heap buffer overflow and user after frees

(cherry picked from commit 8ba00fbe)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

(cherry picked from commit 3a1a8d1d)
Signed-off-by: Jean-Baptiste Kempf <jb@videolan.org>

Sebastian Keller authored 2 years ago and Jean-Baptiste Kempf committed 2 years ago

Reparenting a mapped window to root causes it to become a toplevel
window and can cause window managers to reparent the window themselves
to show their decorations.

This could happen in two situations:

1. Theoretically it could happen briefly between WindowReleased and
   WindowClose.
2. It could trigger a race between VLC and the WM if there is a quick
   sequence of WindowOpen -> WindowReleased -> WindowClose -> WindowOpen
   such as when using single instance mode. If the X-server in this
   situation happens to re-use the XID of the X11 indirection window
   from the first WindowOpen for the second WindowOpen, this could
   result in the following race:
   - VLC creates a new X11 indirection window, reparents and maps it
   - VLC reparents it to root
   - VLC closes the connection, freeing the XID
   - VLC opens a new connection
   - VLC creates a new indirection window with the same XID as before
     and reparents and maps it
   - The X-server sends a MapRequest for the *first* X11 indirection
     window caused by the reparent to root to the WM
   - The WM sees a new toplevel window and reparents it. Because the XID
     used by that reparent request is the same as of the newly created
     indirection window, the new window ends up getting reparented.
   This then would result in the indirection window remaining as
   toplevel window. The exact order might change slightly between the
   different processes, but as long as the reparent request by the WM is
   the last one, the issue will trigger.

Closes #25692

Jean-Baptiste Kempf authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit f133190a)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Marvin Scholz authored 3 years ago and Hugo Beauzée-Luyssen committed 2 years ago

(cherry picked from commit 263b3cbb)
Signed-off-by: Thomas Guillem <thomas@gllm.fr>

Johannes Kauffmann authored 2 years ago and Hugo Beauzée-Luyssen committed 2 years ago

Since live555 2020.12.11, the API has changed. This should fix builds
with the latest version while still allowing contribs to pass.

Ref !1897.
Fixes #25473.

Co-authored-by: Dominic Mayers <dominic.mayers@meditationstudies.org>
Co-authored-by: Pei Jia <jiapei@longervision.com>
(cherry picked from commit 70fedf25)