Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

This patch fixes the issue of wrongly positioned controls that happened in two or more conditions:
1) Interface scale factor is changed
2) ButtonsLayout model is changed (ToolbarEditor is used to change the player controlbar configuration)

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 4 years ago and Pierre Lamot committed 4 years ago

if extraWidth is greater than the implicitWidth (available width is more than what is needed), this patch makes the control limit its width to its implicitWidth

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Benjamin Arnaud authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

Benjamin Arnaud authored 4 years ago and Pierre Lamot committed 4 years ago

Signed-off-by: Pierre Lamot <pierre@videolabs.io>

otherwise the last value is always overwritten with a more recent one
and triggers the dts < pcr case

ref #25034

Close #22534

ref #25518

Bug fixes:
 * Issue 2940: Segfault when encoding with --use-16bit-internal and --limit > 1
 * Issue 2941: Decoder mismatch with --rt --bit-depth=10 and --cpu-used=8
 * Issue 2895: mingw-w64 i686 gcc fails to build
 * Issue 2874: Separate ssse3 functions from sse2 file.

Source: https://aomedia.googlesource.com/aom/+/v3.0.0

fix #21945

fed dts is always bogus as it can't match AU boundaries

Romain Vimont authored 4 years ago and Alexandre Janniaux committed 4 years ago

The function eglInitialize() was called on open, but eglTerminate() was
not called on close or error.

Also remove a wrong call to vlc_object_delete(sys->gl) on error, the
vlc_gl_t is not owned by the module.

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Romain Vimont authored 4 years ago and Alexandre Janniaux committed 4 years ago

Signed-off-by: Alexandre Janniaux <ajanni@videolabs.io>

Otherwise, left/right/top/bottom will not be initialized when used,
probably leading to strange cropping being used. It fixes
-Wmaybe-uninitialized warnings with GCC 10.2.0.

This is exactly the same code as right above.

Michael Kaufmann authored 4 years ago and François Cartegnie committed 4 years ago

MPEG-1 Audio Layer II (MP2) was erroneously detected as ADTS.

MPGA: The previous check used wrong bitmasks (1 bit too far to the right).
The layer check was also wrong, the layer must not be 0.

ADTS: Previously only one bit of the layer was checked. Check both bits.
The check is now identical to the one in HasADTSHeader() in mpeg4audio.c.

References:
- http://mpgedit.org/mpgedit/mpeg_format/mpeghdr.htm
- https://wiki.multimedia.cx/index.php/ADTS



Signed-off-by: Francois Cartegnie <fcvlcdev@free.fr>

So that we don't give an uninitialized field if the structure expands in
dvdnav.

So that we don't give an uninitialized field if the structure expands in
dvdread.

There really is no point having the PTS delay over the frame interval;
it just adds unnecessary latency. This should probably be even lower to
improve streaming responsiveness.

For perfect rendering synchronisation, the change of window size must
be acknowledged after the last picture is rendered in the old size,
and before the first picture is rendered in the new size.

As of c9d6d95f, the window resize is
processed synchronously. This provides for the "after" requirement. But
it failed to address the "before" requirement: the video output thread
can end render a picture so soon after the resize so the window
callback thread has not had time to perform acknowledgement procedures.

This adds a callback to the window resize event which is called before
the display lock (or equivalent) is released. This is guaranteed to be
invoked before the video output thread has the opportunity to render
anything.

Other options were considered:

1) Invoking a callback to the window provider from the video output
   thread code code.
   -> This can delay the callback unreasonably.
   -> Taking the window lock on the video output thread is undesirable
      if at all possible.

2) Invoking a windowing system type-specific callback to the window
   provider from every display of that windowing system.
   -> Same delay and locking problems as 1.
   -> Requires patching several display plugins.

3) Exposing the display lock to the window plugin, via new callbacks.
   -> This leaks internal implementation of the core to window
      providers.
   -> This gets really confusing as some callbacks would need explicit
      locking and others not.

In comparison, this patch seems like the least of evils.

The callback is passed a parameter rather than as a property of the
window to distinguish it from the existing window callbacks which are
not reentrant.

Refs #25112.

Like all other hw plugins.

Without conditional activation of the plugins through autoconf, -rpath
is always defined when adding the plugin libtool archive target to
codec_LTLIBRARIES or nvdec_LTLIBRARIES. If the target's LDFLAGS is not
defined, it will also use AM_LDFLAGS by default.

Sort of revert 1d2b56c6 but it actually
finish the work done in ticket #9367 by removing the last recursive
makefile target in modules/.

It allows faster make (though not significant here) but most of all,
sharing the same variable definition scope in modules/ for all
makefiles.

In particular, this facilitate for future work implementing partial
linking at the module level, which actually needs the list of all
plugins being compiled.

The convenience library factors the mmal libs and the object between the
different plugins.

The plugin's values are not used anymore.