Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
VLC
Manage
Activity
Members
Labels
Plan
Issues
4k
Issue boards
Milestones
Code
Merge requests
450
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Analyze
Contributor analytics
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
VideoLAN
VLC
Commits
f1f05aa2
Commit
f1f05aa2
authored
1 week ago
by
Fatih Uzunoğlu
Committed by
Steve Lhomme
1 week ago
Browse files
Options
Downloads
Patches
Plain Diff
qml: restore header color in certain situations in `TableViewExt`
parent
88a43d43
No related branches found
Branches containing commit
No related tags found
1 merge request
!7048
qt: fix content getting exposed in header in `TableViewExt`
Pipeline
#578899
passed with stage
Stage:
in 12 minutes and 14 seconds
Changes
1
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
modules/gui/qt/widgets/qml/TableViewExt.qml
+9
-1
9 additions, 1 deletion
modules/gui/qt/widgets/qml/TableViewExt.qml
with
9 additions
and
1 deletion
modules/gui/qt/widgets/qml/TableViewExt.qml
+
9
−
1
View file @
f1f05aa2
...
...
@@ -112,7 +112,15 @@ FocusScope {
property
Component
header
:
null
property
Item
headerItem
:
view
.
headerItem
?.
loadedHeader
??
null
property
color
headerColor
:
"
transparent
"
// NOTE: Clipping is not used, so if header is not inline, it should have background to not expose the content.
// TODO: Investigate using clipping here, which makes more sense in general for views. Not using clipping
// makes this view not suitable for using it in auxiliary places (non-main, which is not naturally
// clipped by the window). In order to make use of clipping, the header should be placed outside of
// the view (similar to play queue). This is already a requirement to prevent events reaching to
// the delegate (such as, hovering over the header). As `clip: true` adjusts both the scene graph
// viewport, and qt quick event delivery agent. Having a control as header and blocking the events
// events reaching beneath is not a good behavior, as currently done here.
property
color
headerColor
:
(
interactive
&&
(
headerPositioning
!==
ListView
.
InlineHeader
))
?
colorContext
.
bg
.
primary
:
"
transparent
"
property
int
headerTopPadding
:
0
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment