qt: fix content getting exposed in header in `TableViewExt`
This is because clipping is not used here, so unfortunately if header is not inline and the view is interactive the content is exposed in the header.
We should use clipping here, for both viewport and event delivery (similar to play queue). Qt's ListView.OverlayHeader
and ListView.PullBackHeader
are practically useless, because unless the header/footer is placed outside the view, with these positioning we can not use clipping, and we need to handle the events manually in header and footer to not reach to the content.
I have put a note regarding this situation.
Regression since !7022 (merged).
Request review @chub.
Merge request reports
Activity
and we need to handle the events manually in header and footer to not reach to the content
I can tell that this is already a problem, I can drag the delegate even though I don't see it (as header has background coloring) on header's region that is not covered by
ViewHeader
(Pane
), as we don't handle dragging there (as expected).Using clipping instead of adding a drag handler makes more sense, so I'm not willing to add a drag handler there to fix this another issue.
We don't have this problem in play queue because it uses clipping (which is possible after having the header outside the view). I think if we use header/footer in a view, we should only do that inside the view only with
ListView.InlineHeader
(which is the default).added MRStatus::Reviewable label
added Component::Interface: Qt label
changed milestone to %4.0
added MRStatus::Acceptable label and removed MRStatus::Reviewable label
added MRStatus::Accepted label and removed MRStatus::Acceptable label
MR Acceptance result
This MergeRequest has been Accepted! Congratulations.MR acceptance checks details:
-
MR should be considered mergeable by Gitlab -
Last pipeline should be successful -
MergeRequest should have at least one external review and/or vote -
All threads should be resolved, have votes and score > 0 -
MergeRequest should have no activity (threads/votes) for (72h/72h)
-
added 22 commits
-
250022f6...88a43d43 - 21 commits from branch
videolan:master
- f1f05aa2 - qml: restore header color in certain situations in `TableViewExt`
-
250022f6...88a43d43 - 21 commits from branch
enabled an automatic merge when all merge checks for f1f05aa2 pass