Skip to content
Snippets Groups Projects
Commit e0a99d63 authored by Alaric Senat's avatar Alaric Senat Committed by Steve Lhomme
Browse files

contrib: upnp: disable webserver and device handling

VLC 3.0 uses libupnp exclusively as a client. LibUpnp internals are
quite opaque and it has been observed that a webserver thread is still
running on idle with open sockets even if the library is used as a
client only.

The recent bump to 1.14 introduces regressions in libupnp's webserver
socket initialization [1] on windows. Since the bug is still not
corrected upstream and we don't have any use of the webserver for 3.0
anyway, let's just disable it.

[1] https://github.com/pupnp/pupnp/issues/195

Fixes #27001
parent 39638035
No related branches found
No related tags found
Loading
Pipeline #232069 failed with stages
in 15 minutes and 12 seconds
......@@ -16,7 +16,7 @@ $(TARBALLS)/pupnp-release-$(UPNP_VERSION).tar.gz:
UPNP_CFLAGS := $(CFLAGS) -DUPNP_STATIC_LIB
UPNP_CXXFLAGS := $(CXXFLAGS) -DUPNP_STATIC_LIB
UPNP_CONF := --disable-samples
UPNP_CONF := --disable-samples --disable-device --disable-webserver
ifdef HAVE_WIN32
DEPS_upnp += pthreads $(DEPS_pthreads)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment