Skip to content
Snippets Groups Projects
Commit aaba70b6 authored by Fatih Uzunoğlu's avatar Fatih Uzunoğlu Committed by Steve Lhomme
Browse files

qt: detect Windows 11 22H2 properly in win32windoweffects module

Windows 11 identifies as Windows 10 (NT 10),
so this comparison always yields false.

As a side note, native acrylic background
for Win32 windows only gained support with
the Windows 11 22H2 update, that's why
there is the check here.

Note that according to the general conventions
a transparent window must be frameless on
Windows. This is currently not the case,
because "frameless window don't support
areo snapping". So, it can be considered
as a known bug if native acrylic does not
work as intended. This grants a requirement
of change to use frameless window, and get
rid of the current workaround that simulates
frameless window in mainctx_win32.cpp. If
aero snapping does not work, it is Windows's
problem since we are using frameless windows
in every other platform.
parent 3a4a3dea
No related branches found
No related tags found
Loading
Pipeline #476075 passed with warnings with stage
in 18 minutes and 1 second
......@@ -59,7 +59,7 @@ int QtWin32WindowEffectsOpen(vlc_object_t* p_this)
assert(p_this);
if (QOperatingSystemVersion::current()
< QOperatingSystemVersion(QOperatingSystemVersion::Windows, 11, 0, 22621))
< QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, 22621))
return VLC_EGENERIC;
const auto obj = reinterpret_cast<WindowEffectsModule*>(p_this);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment