qt: detect Windows 11 22H2 properly in win32windoweffects module

Windows 11 identifies as Windows 10 (NT 10), so this comparison always yields false.

QOperatingSystemVersion(QOperatingSystemVersion::Windows, 10, 0, 22621) would also correct this issue, but I opted in to directly use QOperatingSystemVersion::Windows11_22H2 now instead.

As a side note, native acrylic background for Win32 windows only gained support with the Windows 11 22H2 update, that's why there is the check here.

Note that according to the general conventions a transparent window must be frameless on Windows. This is currently not the case, because "frameless window don't support areo snapping". So, it can be considered as a known bug if native acrylic does not work as intended. This grants a requirement of change to use frameless window, and get rid of the current workaround that simulates frameless window in mainctx_win32.cpp. If aero snapping does not work, it is Windows's problem since we are using frameless windows in every other platform.

added MRStatus::Reviewable label

according to the general conventions a transparent window must be frameless on Windows.

Not really, more like they are supposed to have Client Side Decoration, frameless is a Qt concept

"frameless window don't support areo snapping"

this is a Qt problem, not Windows problem.

it can be considered as a known bug if native acrylic does not work as intended.

acrylic is enabled by default on Systems, our application must work

If aero snapping does not work, it is Windows's problem since we are using frameless windows in every other platform.

even on other platform we require some workaround like for window shadow. Note that this is all because of Qt's lacking support for CSD.

added MRStatus::InReview label and removed MRStatus::Reviewable label

I don't understand what this means: does it mean the acrylic blur will only work on Windows 11 ?

added 1 commit

• 3add97b0 - qt: detect Windows 11 22H2 properly in win32windoweffects module

Compare with previous version

resolved all threads

changed milestone to %4.0

added Component::Interface: Qt label

approved this merge request

added MRStatus::Acceptable label and removed MRStatus::InReview label

added MRStatus::Accepted label and removed MRStatus::Acceptable label

MR Acceptance result

This MergeRequest has been Accepted! Congratulations.

MR acceptance checks details:

• MR should be considered mergeable by Gitlab
• Last pipeline should be successful
• MergeRequest should have at least one external review and/or vote
• All threads should be resolved, have votes and score > 0
• MergeRequest should have no activity (threads/votes) for (72h/72h)

This message was automatically generated by homer-bot.

added 200 commits

• 3add97b0...3a4a3dea - 199 commits from branch videolan:master
• aaba70b6 - qt: detect Windows 11 22H2 properly in win32windoweffects module

Compare with previous version

enabled an automatic merge when the pipeline for aaba70b6 succeeds

merged