Proposed changes for issue #162: Request for custom video cover art
1 unresolved thread
1 unresolved thread
Right-click on video now has a 'change cover' option that opens a file picker to select the image file. Tested on W10 and Xbox
Signed-off-by: Martin Finkel martin@videolabs.io
Work by Evan Blackstone.
-
Test on mobile -
Add translations -
Can we trigger an image refresh without rescanning the whole library? -
What if the user selects a huge picture? Is the buffer cleared properly in the helper functions?
Edited by Martin Finkel
Merge request reports
Activity
Filter activity
Would this ensure garbage collection on the buffers correctly?
0001-Reinitialize-byte-array-in-both-SaveMovePictureAsync.patch
86 86 FontFamily="{StaticResource VLCFont}" /> 87 87 </AppBarButton.Icon> 88 88 </AppBarButton> 89 <AppBarButton Label="{Binding Source={StaticResource Strings}, Path=ChangeVideoCover}" Well that's unfortunate...
Can you force a resize for specific languages in the code like this? I have no idea how this looks on mobile, etc. though. Not sure if people that use French would appreciate the change to tiny text in order to accommodate a third button either...
RootGrid.MaxWidth = 450; RootGrid.MaxHeight = 450; if(selectedlanguage == ...){ this.DeleteButton.FontSize = 11; this.ChangeCoverButton.FontSize = 11; this.PlayButton.FontSize = 11; }