Skip to content
Snippets Groups Projects

Proposed changes for issue #162: Request for custom video cover art

Open Martin Finkel requested to merge mfkl/vlc-winrt:feature/custom-video-cover into master
1 unresolved thread

Right-click on video now has a 'change cover' option that opens a file picker to select the image file. Tested on W10 and Xbox

Signed-off-by: Martin Finkel martin@videolabs.io

Work by Evan Blackstone.

  • Test on mobile
  • Add translations
  • Can we trigger an image refresh without rescanning the whole library?
  • What if the user selects a huge picture? Is the buffer cleared properly in the helper functions?
Edited by Martin Finkel

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
86 86 FontFamily="{StaticResource VLCFont}" />
87 87 </AppBarButton.Icon>
88 88 </AppBarButton>
89 <AppBarButton Label="{Binding Source={StaticResource Strings}, Path=ChangeVideoCover}"
  • Author Developer

    The 3 buttons do not display properly in language like French, where the button texts might be bigger. I don't think the vanilla Flyout does auto layout.. this is annoying.

  • Well that's unfortunate...

    Can you force a resize for specific languages in the code like this? I have no idea how this looks on mobile, etc. though. Not sure if people that use French would appreciate the change to tiny text in order to accommodate a third button either...

            RootGrid.MaxWidth = 450;
            RootGrid.MaxHeight = 450;
    
         if(selectedlanguage == ...){
            this.DeleteButton.FontSize = 11;
            this.ChangeCoverButton.FontSize = 11;
            this.PlayButton.FontSize = 11;
          }
  • Author Developer

    Can you force a resize for specific languages in the code like this?

    That's not the way to go. What if you have 300 languages? I'll give it another look later.

  • Please register or sign in to reply
Please register or sign in to reply
Loading