SettingsController: Rework custom seek duration option
- Oct 12, 2023
-
-
Cosmetics changes in order to improve the readability.
c2566183 -
Cosmetics changes in order to improve the readability.
ce4c70cf -
Some adjustments were required regarding the seek duration display after the custom seek duration option rework.
1d9bfc9a -
Playback Controls Settings: new variable, constants, and settings for gesture control duration forward/backward. In a functional state. Player Skip Controls: New settings to group Forward/Backward skips, and Tap/Gesture skips TODO: Hide/Show skip duration options in VLC settings depending on what skip groups are enabled/disabled. This means that we cannot pick skip durations from iOS Settings anymore (cannot dynamically hide/show cells) Player Skip Control: Hide and show cells depending on skip groups selected. Reload Settings table view on change of either of the skip group options. Cells are set to height 0 and hidden if skip groups are enabled. Implemented similarly as a delegate that passes the UITableViewController to the Cell if required. Additional cells added to SettingsSection so that the new skip groups are visible in the in-app settings. Additionally, the description for the skip options is dynamic and changes depending on which skip groups are active. (Forward skip becomes forward tap skip if neither skip groups are active, or it becomes "Skip" if both groups are active, for example). Additionally, a new String optional playbackTitle is passed to the action sheet if the sheet is opening a skip duration menu. This is so the dynamic description is passed to the action sheet header. New localizable strings for all possible mutations of skip options. Playback Skip Control: Audio/Video players react to skip changes. Depending on the skip groups, skips change. They work accordingly with the groups and values set. For example, if tap/gesture and forward/backward skip groups are both set to true, then all skips follow the seekForwardBy variable. Player Skip Control: Rebase into Diogo's changes, fix comma spacing violationg Skip Duration Fixes: Change wording Change localizable text to sound more natural for skip options. Edit wording from "gesture" to "swipe" for every reference to seek swipe Skip Duration Settings: Cache the UserDefaults for audio/video player cache the userDefaults used in the viewWillAppear function for accessing the skip duration settings. Seek options: shift code-block from AudioPlayer to super class PlayerView This is done for future proofing. Once VideoPlayer will extend PlayerView, we can get rid of code duplication.
72c42f96
-