Skip to content
Snippets Groups Projects

Playback Controls Settings: Skip Duration Customizability (fixes #1685)

Closed Avi Wadhwa requested to merge aviwad/vlc-ios:gestureDurationCustom into master
All threads resolved!

There are a total of 4 different skip options:

  • Forward & Tap,
  • Backward & Tap,
  • Forward & Gesture,
  • Backward & Gesture.

To prevent the monstrosity of 4 options, I decided to add 2 new toggles that group these skips together: Forward = Backward, and Tap = Gesture.

The code dynamically hides the respective cells for skips depending on which "skip groups" are toggled. Additionally, the audio and video players correctly skip based on the toggles and read from the correct kVLC values.

Additions:

  • 4 new kVLC values (4 new kVLC defaults).
  • 2 new toggles available in Settings.app, 2 new toggles and 2 new skip options in the in-app settings.
  • Audio and Video player now have 4 new variables (for the two skip groups, and 2 gesture seek durations)
  • New delegate that passes the UITableViewController to the settings cell when needed (allows us to reload the settings when skip groups are toggled).
  • New String optional passed to the Action sheet handler (passes the dynamic skip description to the action header title).
  • 7 new localizable strings.

Removals: Cannot set the skip duration within Settings.app. This has moreso to do with the limitation Apple sets. I am unable to change the skip cell name, or hide or show them based on the toggle. Letting the user set 4 different skips if the user already selected to group all 4 together is bad UI.

Attached is a screen recording. :smile:

Simulator_Screen_Recording_-iPhone_14-_2023-07-05_at_02.33.31

Edited by Avi Wadhwa

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Felix Paul Kühne
  • Felix Paul Kühne
  • Felix Paul Kühne
  • Felix Paul Kühne
  • Felix Paul Kühne
  • Avi Wadhwa added 1 commit

    added 1 commit

    • 1274aead - Skip Duration Fixes: Change wording

    Compare with previous version

  • Avi Wadhwa added 1 commit

    added 1 commit

    • 487b9914 - Skip Duration Settings: Cache the UserDefaults for audio/video player

    Compare with previous version

  • Avi Wadhwa resolved all threads

    resolved all threads

  • Avi Wadhwa resolved all threads

    resolved all threads

  • Diogo Simao Marques
  • Diogo Simao Marques approved this merge request

    approved this merge request

  • Avi Wadhwa resolved all threads

    resolved all threads

  • Avi Wadhwa added 1 commit

    added 1 commit

    • 9edfe09a - Seek options: shift code-block from AudioPlayer to super class PlayerView

    Compare with previous version

  • Avi Wadhwa added 17 commits

    added 17 commits

    • 9edfe09a...d697866d - 9 commits from branch videolan:master
    • fb7d3d00 - Playback Controls Settings: new variable, constants, and settings for gesture...
    • cefd3175 - Player Skip Controls: New settings to group Forward/Backward skips, and Tap/Gesture skips
    • 799382a7 - Player Skip Control: Hide and show cells depending on skip groups selected.
    • e6491756 - Playback Skip Control: Audio/Video players react to skip changes.
    • 9bdd9f2b - Player Skip Control: Rebase into Diogo's changes, fix comma spacing violationg
    • 4333d57c - Skip Duration Fixes: Change wording
    • a97ca065 - Skip Duration Settings: Cache the UserDefaults for audio/video player
    • 4307fcda - Seek options: shift code-block from AudioPlayer to super class PlayerView

    Compare with previous version

  • Author Contributor

    Solved merge conflicts.

  • Diogo Simao Marques resolved all threads

    resolved all threads

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • @aviwad could you rebase once more so we can merge?

  • Author Contributor

    @fkuehne will rebase this one and the siri one today

  • Author Contributor

    Hi. Will rebase sometime this week. My university has just reopened.

  • @aviwad any chance of a rebase?

  • Diogo Simao Marques mentioned in merge request !1132 (merged)

    mentioned in merge request !1132 (merged)

  • Opened a different merge request with the rebase.

    The commits were squashed because they did not compile individually.

    I am therefore closing this one.

  • Please register or sign in to reply
    Loading