Skip to content
Snippets Groups Projects

Audio Player: Hide system volume indicator, show VLC Volume indicator on volume change

Merged Avi Wadhwa requested to merge aviwad/vlc-ios:fixAudioPlayerVolume into master
All threads resolved!

Brings Audio player behaviour on par with Video player in terms of volume control. Volume change from physical buttons are now handled by the VLC component rather than the system volume bar. Volume change through the gesture is solely handled by the VLC component (the system volume bar is set to an alpha of ~0)

Before merge request:

RPReplay_Final1687002226

After merge request:

RPReplay_Final1687002253

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I would put the code for the viewDidLoad method in the Init section of the file, the hideSystemVolumeInfo and setupObservers in the Private methods section and the observeValue in the Public methods section.

    Otherwise, it LGTM!

    Edited by Diogo Simao Marques
  • Diogo Simao Marques changed milestone to %3.4.6

    changed milestone to %3.4.6

  • Diogo Simao Marques approved this merge request

    approved this merge request

  • Avi Wadhwa resolved all threads

    resolved all threads

  • Avi Wadhwa added 1 commit

    added 1 commit

    • 010651d5 - Audio Player: Hide system volume indicator, show VLC Volume indicator on volume change

    Compare with previous version

  • Author Contributor

    Amended the commit with the required fixes :) the methods are in their respective sections, and the indentation has been fixed.

  • Felix Paul Kühne approved this merge request

    approved this merge request

  • Please register or sign in to reply
    Loading