Skip to content
Commit 5a658d7c authored by Nicolas Pomepuy's avatar Nicolas Pomepuy
Browse files

Convert align mode setting to proper ellipsize setting

parent 8d41cc47
Loading
Loading
Loading
Pipeline #8980 passed with stage
in 4 minutes and 42 seconds
Loading
  • @Aza what is the difference between the new settings Default and Marquee? Does both turn the effect on and Right turn it off? It eill be needed for a better translation.

  • Author Maintainer

    Default is the default implementation (mostly the same as right).

    Marquee makes the text scroll automatically

  • Yes, the functions are known but it wasn't clear how they are set here. I could test the new setting now and the Default setting is the old Marquee setting from: #853 (closed), where this effect starts after some scroll steps and was already criticized here. The new Marquee setting starts from the beginning, which is better. I don't know if we still need the old Marquee setting here but the default setting should be definitely Right, and is actually not needed if Right is checked from the beginning. It's harder to conclude which setting is Default.

    Edited by Michał Trzebiatowski
  • Author Maintainer

    To be sure I understand, you suggest that all default states (in all lists) should be Right and that the Default option would not be needed anymore (and Right would be checked by default).

    Am I right?

    If so, I agree with that.

  • Yes, that would be also my thought.

    But there is a small nice feature on the Default setting and would be lost: you can control the Marquee effect a little bit manually, it starts when you start to scroll. On some one page folders you might not need Marquee, it's probably better to have Right to see the beginning track numbers. And on others with longer titles Marquee is useful. This could be solved when you get more control over this effect from inside the lists. Something similar to the sorting function in the top title bar that is settable for different subfolders. How about the idea to putting this ellipsize function in a new entry/icon to the top bar and set it for each folder individually just like the sorting function? It depends if this setting is only used on the lists or somewhere else (history? audio player titles? info card title?). And without the Default value of course. It could be a feature request if liked.


    There is a small question from the translators about this string.

    How do we translate this (Single line list title ellipsize)?

    • "single line list" or
    • "single line" and "list title"
    Edited by Michał Trzebiatowski
  • Author Maintainer

    After further discussion, we want to keep it that way.

    Default: is the default implementation and allow us to customize the effect depending on the view itself

    The marquee effect has been uniformized and is now only launched a few seconds after the view appears on screen. (Merge request to come)

    I agree the wording is not ideal, but I don't see how to make it clearer. Here is an explanation: The ellipsize settings will only be applied on titles in lists having one line.

  • Is the old setting Centre the new Middle here? And does Centre exist in the menu? The translations for both words would be similar.

  • Author Maintainer
  • OK, so what is the function for list_title_alignment_centre here? Is it still needed?

    Edited by Michał Trzebiatowski
  • Author Maintainer

    It is not used anymore. Thanks for noticing it. i will remove this string in a future commit.

  • Can this be removed soon? It would be good to do this before the next translation update.

  • Author Maintainer

    Done.

0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment