Convert align mode setting to proper ellipsize setting
-
@Aza what is the difference between the new settings
Default
andMarquee
? Does both turn the effect on andRight
turn it off? It eill be needed for a better translation. -
Yes, the functions are known but it wasn't clear how they are set here. I could test the new setting now and the
Default
setting is the oldMarquee
setting from: #853 (closed), where this effect starts after some scroll steps and was already criticized here. The newMarquee
setting starts from the beginning, which is better. I don't know if we still need the oldMarquee
setting here but the default setting should be definitelyRight
, and is actually not needed ifRight
is checked from the beginning. It's harder to conclude which setting isDefault
.Edited by Michał Trzebiatowski -
Yes, that would be also my thought.
But there is a small nice feature on the
Default
setting and would be lost: you can control theMarquee
effect a little bit manually, it starts when you start to scroll. On some one page folders you might not needMarquee
, it's probably better to haveRight
to see the beginning track numbers. And on others with longer titlesMarquee
is useful. This could be solved when you get more control over this effect from inside the lists. Something similar to the sorting function in the top title bar that is settable for different subfolders. How about the idea to putting this ellipsize function in a new entry/icon to the top bar and set it for each folder individually just like the sorting function? It depends if this setting is only used on the lists or somewhere else (history? audio player titles? info card title?). And without theDefault
value of course. It could be a feature request if liked.
There is a small question from the translators about this string.How do we translate this (Single line list title ellipsize)?
- "single line list" or
- "single line" and "list title"
Edited by Michał Trzebiatowski -
After further discussion, we want to keep it that way.
Default: is the default implementation and allow us to customize the effect depending on the view itself
The marquee effect has been uniformized and is now only launched a few seconds after the view appears on screen. (Merge request to come)
I agree the wording is not ideal, but I don't see how to make it clearer. Here is an explanation: The ellipsize settings will only be applied on titles in lists having one line.
-
The values for this setting are available here: https://code.videolan.org/videolan/vlc-android/blob/5a658d7cfb61c2b0fedd78bd5df1cac959e1b9cf/vlc-android/res/values/arrays.xml#L249
- Default
- Left
- Right
- Middle
- Marquee
-
OK, so what is the function for
list_title_alignment_centre
here? Is it still needed?Edited by Michał Trzebiatowski