Skip to content
Snippets Groups Projects

Check for the PiP permission

Merged Nicolas Pomepuy requested to merge Aza/vlc-android:pip_perm into master
1 unresolved thread

Fixes #2584 (closed) The check is done before launching the PiP playback and when the setting is changed in the app

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
255 276 textId = R.string.allow_sdraw_overlays_description
256 277 action = android.provider.Settings.ACTION_MANAGE_OVERLAY_PERMISSION
257 278 }
279 PERMISSION_PIP -> {
280 titleId = R.string.allow_pip
281 textId = R.string.allow_pip_description
282 action = "android.settings.PICTURE_IN_PICTURE_SETTINGS"
  • Author Maintainer

    I wasn't able to use android.provider.Settings.ACTION_PICTURE_IN_PICTURE_SETTINGS here because it wouldn't compile. Maybe this API is too recent to be retrieved at this point (or maybe we have to bump our target SDK version)

    Edited by Nicolas Pomepuy
  • Please register or sign in to reply
  • Duncan McNamara approved this merge request

    approved this merge request

  • Duncan McNamara added 5 commits

    added 5 commits

    Compare with previous version

  • Duncan McNamara enabled an automatic merge when the pipeline for 5733b2a4 succeeds

    enabled an automatic merge when the pipeline for 5733b2a4 succeeds

  • Please register or sign in to reply
    Loading