Expose dvdnav_jump_to_sector_by_time (!45) · Merge requests · VideoLAN / libdvdnav

Merged Miguel Borges de Freitas requested to merge miguelborgesdefreitas/libdvdnav:exposejumpbytime into master 2 years ago

This brings up our last (valid) patch for libdvdnav, mostly for comments as I am a bit unsure.

Kodi and other applications seem to rely solely on this function despite being "experimental" for years. I believe the reason this is not on the header is the fact the implementation is incomplete and only mode 0 is currently implemented.

VLC also exposes it internally: https://github.com/videolan/vlc/blob/79d852d5be832729375860f9d9fce0e3d391aa89/modules/access/dvdnav.c#L57-L58

So if everyone uses it, why not expose it on the header file even if incomplete to simplify our life? It's also one of the most documented functions available on the lib.

If this is refused, we can try to expose it internally like VLC ofc. Just thought it's worth a try.