Provide a way of obtaining the dvd volume id

In Kodi we fill a dvd label using dvdnav_get_serial_string to provide a string for skins to use:

However in our version of libdvdnav XBMC hack the filling of dvd->name by also obtaining the info from the DVD volume if the title string could not be obtained: https://github.com/xbmc/libdvdnav/commit/48607e689662f21210905ac75ac21424f764fcde

I don't think this is a clean solution as it violates the single responsibility principle and mixes up different data on the same source of information. Hence this PR adds dvdnav_get_volid_string as an alternative giving that the client/application can fallback to it if dvdnav_get_serial_string fails. We could already do this using dvdreader only but that would require going via DVDOpen for a disc that is already open (the dvd_reader_t pointer is private to the VM).

Good addition.

resolved all threads

Sorry, but why don’t we allocate the string instead of having requirements on parameters passed in the function call?

added 2 commits

• dc20c77e - add dvdnav_get_volid_string
• 4493309e - Update NEWS with dvdnav_get_volid_string addition

Compare with previous version

resolved all threads

resolved all threads

added 2 commits

• 31de63be - add dvdnav_get_volid_string
• 935cbdda - Update NEWS with dvdnav_get_volid_string addition

Compare with previous version

added 2 commits

• f5a17889 - add dvdnav_get_volid_string
• 35bd5143 - Update NEWS with dvdnav_get_volid_string addition

Compare with previous version

resolved all threads

approved this merge request

merged