Remove VLCEventManager and replace processing

An attempt to remove the VLCEventManager and replace the process. This will increase performance.

An example of improvement

// VLCMediaPlayerDelegate
func mediaPlayerStateChanged(_ aNotification: Notification) {
    guard let mediaPlayer = aNotification.object as? VLCMediaPlayer else { return }
    let currentState: VLCMediaPlayerState = mediaPlayer.state
    print(currentState)
}

• At the start of playback

before

// print result
VLCMediaPlayerState.buffering = 2

after

// print result
VLCMediaPlayerState.opening = 1
VLCMediaPlayerState.buffering = 2
VLCMediaPlayerState.esAdded = 7
VLCMediaPlayerState.esAdded = 7
VLCMediaPlayerState.playing = 5
VLCMediaPlayerState.buffering = 2
VLCMediaPlayerState.buffering = 2
VLCMediaPlayerState.buffering = 2
VLCMediaPlayerState.buffering = 2

• 404 At URL playback start

before

// print result
VLCMediaPlayerState.buffering = 2
VLCMediaPlayerState.stopped = 0

after

// print result
VLCMediaPlayerState.opening = 1
VLCMediaPlayerState.buffering = 2
VLCMediaPlayerState.error = 4
VLCMediaPlayerState.stopped = 0

This should fix the #80, #129 (closed), #428 (closed), #459 (closed), #578 (closed) issues.

If this attempt is not suitable, please close this merge request.

best regards.

added 1 commit

• b21265ac - Remove VLCEventManager and replace processing

Compare with previous version

requested review from @umxprime

changed the description

mentioned in merge request !131 (closed)

Hi @Sumou and thanks for the proposal. I have opened another one in !131 (closed) and while mine will try to preserve some of the former mechanisms, yours is also nice and straightforward. Would you like to join in the conversation about it ?

changed the description

added 1 commit

• aec02a79 - Remove VLCEventManager and replace processing

Compare with previous version

What is the status about this and !131 (closed)?

approved this merge request

marked this merge request as ready

approved this merge request

added 6 commits

• aec02a79...21557a84 - 5 commits from branch videolan:3.0
• 4945df06 - Remove VLCEventManager and replace processing

Compare with previous version

changed milestone to %4.0

enabled an automatic merge when the pipeline for 4945df06 succeeds

Great work, thanks again for your continued contributions!

Nice work @Sumou

merged

mentioned in issue #610 (closed)

@Sumou Would you mind to forward port it to master ?

@umxprime Yes, gladly!

mentioned in merge request !193 (merged)

mentioned in issue #459 (closed)

mentioned in issue #578 (closed)

mentioned in issue vlc-ios#1466 (closed)